* Use flex to stop redundant margin-top from appearing
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove ButtonResetDefault which resets nothing
It should be avoided to use ButtonResetDefault where there is nothing to be reset, in order to prevent resources from being wasted.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Ensure that unexpected regressions will never happen on the buttons and their icons
Rules can be extracted when needed. Until then there is no point of exposing elements to possible regressions, which could easily happen on the current architecture.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use SASS variables and remove a redundant declaration
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Specify the button style explicitly removing the dependency on the mixin
The reset mixin can cause style inconsistencies by disrupting cascading arbitrarily, increasing the number of specified declarations more than needed. Though it might be useful for development, it is not necessary to use it, makes it difficult to grasp the style structure, and can be removed to optimize the structure.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove element='button' from AccessibleButton
Since AccessibleButton has role='button' by default, setting the element button property is redundant.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Protect mx_ShareType_option from being regressed structurally
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* yarn run lint:style --fix
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Wrap buttons with declarations for spacing
box-sizing is not required for the buttons or the wrapper.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* yarn run lint:style --fix
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* fix eslint errors
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Fix LocationShareMenu-test.tsx
AccessibleButton is div by default
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Reflect the review
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Revert "Remove element='button' from AccessibleButton"
This reverts commit af78d2713f6b4fca9405498e0090db1e6218ff1b.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Revert "Fix LocationShareMenu-test.tsx"
This reverts commit 7d783a733ec84af6453b2359b2d00443fcece2ef.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* add state for waiting for labs flag
Signed-off-by: Kerry Archibald <kerrya@element.io>
* add enable live share component
Signed-off-by: Kerry Archibald <kerrya@element.io>
* test enabling live share labs flag
Signed-off-by: Kerry Archibald <kerrya@element.io>
