Commit Graph

3650 Commits

Author SHA1 Message Date
Kerry
f20d86b7b8
Device manager - logout current session (PSG-743) (#9275)
* trigger verification of other devices

* add sign out of current device section in device details

* fix classname

* lint

* strict type fix

* fix test

* improve mocked VerifReq
2022-09-14 14:37:36 +02:00
Matthew Hodgson
8bc03aabba
remove the grey gradient on images in bubbles in the timeline (#9241)
* remove the grey gradient on images in the timeline

given we now show timestamps with a nice lozenge overlay,
so the gradient is unnecessary and just screws up the image.

fixes https://github.com/vector-im/element-web/issues/21651

* put a lozenge on the timestamp rather than evil gradient
2022-09-08 15:54:35 +01:00
Janne Mareike Koschinski
b651b1c0c5
Fix issue with quiet zone around QR code (#9243) 2022-09-07 13:11:40 +02:00
Robin
4524291331
Fix the picture-in-picture component being off screen (#9246) 2022-09-06 04:28:01 +00:00
Robin
0d6a550c33
Prepare for Element Call integration (#9224)
* Improve accessibility and testability of Tooltip

Adding a role to Tooltip was motivated by React Testing Library's
reliance on accessibility-related attributes to locate elements.

* Make the ReadyWatchingStore constructor safer

The ReadyWatchingStore constructor previously had a chance to
immediately call onReady, which was dangerous because it was potentially
calling the derived class's onReady at a point when the derived class
hadn't even finished construction yet. In normal usage, I guess this
never was a problem, but it was causing some of the tests I was writing
to crash. This is solved by separating out the onReady call into a start
method.

* Rename 1:1 call components to 'LegacyCall'

to reflect the fact that they're slated for removal, and to not clash
with the new Call code.

* Refactor VideoChannelStore into Call and CallStore

Call is an abstract class that currently only has a Jitsi
implementation, but this will make it easy to later add an Element Call
implementation.

* Remove WidgetReady, ClientReady, and ForceHangupCall hacks

These are no longer used by the new Jitsi call implementation, and can
be removed.

* yarn i18n

* Delete call map entries instead of inserting nulls

* Allow multiple active calls and consolidate call listeners

* Fix a race condition when creating a video room

* Un-hardcode the media device fallback labels

* Apply misc code review fixes

* yarn i18n

* Disconnect from calls more politely on logout

* Fix some strict mode errors

* Fix another updateRoom race condition
2022-08-30 15:13:39 -04:00
Kerry
825a0af4a9
Device manager - device type and verification icons on device tile (PSG-637) (#9197)
* add unknown device icon

* add device type and verification icon component

* test

* stylelint

* fix securitycard spacing

Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-08-29 10:48:00 +00:00
Michael Telatynski
e269c6895d
Fix url preview AXE and layout issue & add percy test (#9189) 2022-08-17 16:07:18 +00:00
Gustavo Santos
80d0159150
Add gap between checkbox and text in report dialog (#9195) 2022-08-17 11:49:50 +00:00
Kerry
0dffc582e7
Device manager - current session expandable details (PSG-644) (#9185)
* split current device section into component

* add dropdown button for currentsession device details

* test currentdevicesection

* remove unnecc beforeEach

* update type imports

* i18n and lint
2022-08-15 17:30:18 +02:00
Janne Mareike Koschinski
9eaf48b176
The Welcome Home Screen: Return Button (#9089)
* Implement button to return to user onboarding screen
* Add analytics events
* Increase stability of lazy loading test
2022-08-12 12:55:31 +02:00
Michael Telatynski
3b64a7999c
Override the disambiguated profile colour in percy tests for screenshot consistency (#9161) 2022-08-10 07:20:29 +00:00
Kerry
5a9c2e530a
Device manager - selectable device tile wrapper (PSG-637) (#9153)
* add selectabledevicetile wrapper

* set pointer cursor

* line up own device icon with new checkboxes
2022-08-09 13:07:25 +00:00
Kerry
eb2e61e9cf
Device manager: generic settings subsection component (PSG-636) (#9147)
* add feature_new_device_manager labs flag

* add generic settings tab container

* settingstab section styles

* add session manager tab to user settings

* add sessions tab case to UserSettingDialog test

* fussy import ordering

* remove posthog tracking

* i18n

* add generic settings subsection component
2022-08-09 10:14:30 +02:00
Kerry
ed67aec334
Device Manager - add new labsed session manager screen (PSG-636) (#9119)
* add feature_new_device_manager labs flag

* add generic settings tab container

* settingstab section styles

* add session manager tab to user settings

* add sessions tab case to UserSettingDialog test

* fussy import ordering

* remove posthog tracking

* i18n
2022-08-08 13:51:00 +00:00
Janne Mareike Koschinski
cb15222594
Make percy snapshots for user onboarding more reliable (#9132)
* Make percy snapshots for user onboarding more reliable
* Increase stability of lazy loading test

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-08-08 13:17:04 +02:00
Janne Mareike Koschinski
b62413d725
The Welcome Home Screen: Dedicated Download Apps Dialog (#9120)
* Implement new download apps dialog
* Added screenshot test for app download dialog
2022-08-02 16:08:02 +02:00
Janne Mareike Koschinski
91a24c411b
Implement feedback section for user onboarding list (#9090) 2022-08-01 16:01:27 +02:00
Michael Telatynski
d5db131eef
Spike AXE A11Y testing in Cypress (#9111)
* Spike AXE A11Y testing in Cypress

* Fix NewRoomIntro breaking html/aria list rules

* Fix HeaderButtons breaking aria role semantics rules

* missing type

* Switch left panel from aside to nav and include space panel

* Give the page a main heading of the room name when viewing a room

* Use header landmark on RoomHeader

* Improve aria attributes on composer when autocomplete is closed

* Fix aria-owns on RoomHeader

* Give Spinner an aria role

* Give server picker help button an aria label

* Improve auth aria attributes and semantics

* Improve heading semantics in use case selection screen

* Fix autocomplete attribute to be valid

* Fix heading semantics on login page

* Improve Cypress axe testing

* Add axe tests

* Stop synapse after the timeline tests

* Await spinners to fade before percy snapshotting timeline tests

* Improve naming of plugin

* Update snapshots

* Fix accidental heading change

* Fix double synapse stoppage

* Fix Cypress timeline avatar assertions to be DPI agnostic

* Fix aria attributes on date separators

* delint

* Update snapshots

* Revert style change

* Skip redundant call
2022-08-01 08:31:14 +01:00
Suguru Hirahara
82fb21aff5
Apply inline start padding to selected lines on modern layout only (#9006) 2022-08-01 08:19:22 +02:00
Janne Mareike Koschinski
1e4c336fed
New User Onboarding Task List (#9083)
* Improve type of AccessibleButton to accurately represent available props
* Update analytics events
2022-07-29 11:43:29 +00:00
Šimon Brandner
bd30b75f79
Add support for disabling spell checking (#8604)
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-07-28 08:10:04 +00:00
Germain
72c24af5c0
Disallow invalid inline style comments in stylesheets (#9099) 2022-07-27 14:39:29 +01:00
Michael Telatynski
8eeeee1aa2
Use default styling on nested numbered lists due to MD being sensitive (#9110) 2022-07-27 14:38:34 +01:00
Michael Telatynski
d2b942de42
Fix avatars in percy not having the right border radius (#9102)
* Fix avatars in percy not having the right border radius

* Fix percy media for base avatars
2022-07-26 16:39:17 +01:00
Kerry
594439222d
Replace mask-images with svg components in MessageActionBar (#9088)
* Use svg components in messageactionbar

* highlight options button in pinned messages mock buttons
2022-07-25 12:43:41 +02:00
Šimon Brandner
bc30713b5e
Use flex-end instead of end (#9094) 2022-07-25 11:14:01 +02:00
Suguru Hirahara
92fce71e39
Align the right edge of info tile lines with normal ones on IRC layout (#9058)
* Apply inline start margin to info event tile line to align the right edge with normal event tile lines

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Rename the variable

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add a test to check inline start margin

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Rerun CI

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Improve tests a little bit

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-25 10:05:32 +01:00
Šimon Brandner
787ace9dc5
Add Reply in thread button to the right-click message context-menu (#9004) 2022-07-23 12:13:49 +00:00
Michael Weimann
9edd49818c
Prepare room components for local rooms (#9082) 2022-07-20 15:07:06 +02:00
Suguru Hirahara
38a913488f
Improve clickability of view source event toggle button (#9068)
* Improve clickability of view source event toggle button

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix compression

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Make it easy to select subsequent events

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-18 09:41:01 +02:00
Suguru Hirahara
b90ea87d11
Re-add inline start padding to EventTile_line of GenericEventListSummary (#9063) 2022-07-16 12:15:12 +00:00
Suguru Hirahara
161a333a51
Improve clickability of "collapse" link button on bubble layout (#9037) 2022-07-16 09:31:29 +00:00
yaya-usman
017f489be6 nits fixes 2022-07-15 22:55:11 +03:00
Michael Telatynski
01f4bb8c78
Rename PostCSS files to .pcss (#9013)
* Rename PostCSS files to `.pcss`

* Make Stylelint happy

* Delint

* Rename new files too

* delint

* Fix bad comment placement
2022-07-15 14:53:23 +01:00
Janne Mareike Koschinski
f5f79158ed
Implement Use Case Selection screen (#8984)
* Introduce new splash page wrapper
* Introduce new use case selection screen
2022-07-13 15:43:44 +02:00
Suguru Hirahara
a269e3ebad
Move &.mx_EventTile_isEditing and &.mx_EventTile_selected out of mx_EventTile:not([data-layout=bubble]) (#8980)
* Move &.mx_EventTile_isEditing and &.mx_EventTile_selected out of mx_EventTile:not([data-layout=bubble])

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use common variables for selected lines and hovered lines

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style blocks for mx_EventTile_line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-13 00:24:06 +00:00
Suguru Hirahara
49339b333d
Fix warning about 'start' value usage (#9050)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-12 21:51:05 +00:00
Suguru Hirahara
ae925fb1e9
Remove :not() pseudo class from mx_EventTile_line:hover of ThreadsList (#9021)
* Remove :not() pseudo class from mx_EventTile_line:hover of ThreadsList

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style blocks

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move style rules down

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add comments

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply &:hover globally to realize the original implementation

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-12 15:31:07 -06:00
Suguru Hirahara
49c6d10ddb
Manage style rules of ReadReceiptGroup position on one file (#8993)
* Specify positon of RR on IRC layout on _EventTile.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Manage a declaration for position of RR on modern/group layout on _EventTile.scss, instead of applying it as a default one

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use logical properties

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_ReadReceiptGroup in mx_EventTile_msgOption to prevent a regression

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Manage style blocks of mx_ReadReceiptGroup for every layout on one file

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use logical properties

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_ReadReceiptGroup in mx_EventTile_msgOption for bubble layout same as the other layouts

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_ReadReceiptGroup in mx_EventTile_msgOption on TimelineCard

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-12 15:30:59 -06:00
Suguru Hirahara
c175263fd7
Move mx_EventTile_info out of mx_EventTile:not([data-layout=bubble]) (#8994)
* Move mx_EventTile_info .mx_EventTile_line from mx_EventTile:not([data-layout=bubble]) to mx_EventTile[data-layout=group]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move style rules for avatar and E2E icon of mx_EventTile_info .mx_EventTile_line from mx_EventTile:not([data-layout=bubble]) to mx_EventTile[data-layout=group]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move mx_EventTile_info out of mx_EventTile:not([data-layout=bubble]) for both IRC and modern layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply the style rule for mx_MessageTimestamp on info event tile line to group layout only

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply zero padding-top to modern/group layout only (IRC layout has zero padding by default)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply avatar position settings to modern/group layout only

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Maintain the style block for avatar on info event tile in IRC layout on _EventTile.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove obsolete style block

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove inline padding setting from mx_EventTile_line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a correct variable

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix misalignment of avatars and textual events on IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Align avatars and hidden events on IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-12 13:40:19 +00:00
Janne Mareike Koschinski
780a903e2f
Improve spotlight accessibility by adding context menus (#8907)
* Extract room general context menu from roomtile
* Create hook to access and change a room’s notification state
* Extract room notification context menu from roomtile
* Add room context menus to rooms in spotlight
* Make arrow movement apply to the whole dialog, not just the input box
2022-07-12 15:03:08 +02:00
Suguru Hirahara
2587aa1369
Add space for the stroke on message editor on IRC layout (#9030)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-11 17:19:49 -04:00
Robin
17699dfcd0
Don't unnecessarily persist the host signup dialog (#9043)
https://github.com/matrix-org/matrix-react-sdk/pull/8747 made it more evident that the host signup dialog was relying on some quirks in how PersistedElement sizes and positions things that it probably shouldn't have been relying on. As far as I can tell, this dialog doesn't *need* to be a PersistedElement at all since it's mounted manually as part of LoggedInView, and so it doesn't look like there's any way for it to unexpectedly disappear on the user.

According to Travis this is supposed to be a bespoke widget in a proper dialog, but this is intended as a more short-term fix.
2022-07-11 16:50:13 -04:00
Suguru Hirahara
d1928d2cb3
Remove obsolete opacity value for E2E icons (#8975)
* Remove obsolete opacity value for E2E icons

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* The opacity declaration is not required after all

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-11 07:46:31 +02:00
Suguru Hirahara
03ce8ae323
Enable search strings highlight on bubble layout (#9032)
* Move mx_EventTile_searchHighlight out of mx_EventTile:not([data-layout=bubble]) to enable it on bubble layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a logical property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-09 13:29:45 +02:00
Suguru Hirahara
4fb11968fa
Move style declarations out of :not([data-layout=bubble]) in ThreadView (#9020)
* Move mx_EventTile out of mx_EventTile:not([data-layout=bubble]) in mx_ThreadView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a logical property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a redundant declaration

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply zero inline start padding to group layout only

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Reorder style blocks; irc/group before bubble

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move styles for mx_EventTile_avatar of info event lines on ThreadView out of :not() pseudo class

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move styles in mx_GenericEventListSummary on ThreadView out of :not() pseudo class

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Shorthand for inline margin

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-08 11:38:06 +02:00
Suguru Hirahara
b1f8d36a69
Re-add margin to tiles based on EventTileBubble (#9015)
* Re-add margin to HistoryTile, which is based on EventTileBubble

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Readd margin to the other tiles based on EventTileBubble

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Default margin is not required for mx_MJitsiWidgetEvent as it appears inside EventTile

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Cancel left value for cryptoEvent on IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-08 09:58:49 +01:00
Suguru Hirahara
4844cc14bd
Remove padding from event info line for hidden events on ThreadView (#9019)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-08 08:39:20 +02:00
Suguru Hirahara
bd8949872d
Fix lost padding of event tile info line (#9009)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-07 15:08:32 +02:00
Suguru Hirahara
56258bcdb6
Improve _GenericEventListSummary.scss (#9005)
* Include mx_BaseAvatar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include style blocks of mx_MatrixChat_useCompactLayout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set top padding to avatars on group layout only

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a redundant declaration for bubble layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set the same margin value to mx_GenericEventListSummary_avatars on every layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove margin-top from mx_GenericEventListSummary_toggle on IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove block margin from mx_GenericEventListSummary_toggle on both IRC layout and modern layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set spacing to mx_GenericEventListSummary instead of its child elements

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply the margin to every layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move general rules up

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply block margin to mx_GenericEventListSummary_toggle of every layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply top margin to modern layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_MatrixChat_useCompactLayout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set top margin to mx_GenericEventListSummary insted of toggle

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a spacing variable

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a redundant declaration

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add a comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply display flex as a default value

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-07 14:01:37 +02:00