Merge pull request #3599 from MarcoZehe/fix-breadcrumb-a11y

Fix breadcrumbs so the bar is a toolbar and the buttons are buttons.
This commit is contained in:
Michael Telatynski 2019-11-07 17:03:26 +00:00 committed by GitHub
commit e864a20cd8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -353,7 +353,6 @@ export default class RoomBreadcrumbs extends React.Component {
onMouseEnter={() => this._onMouseEnter(r.room)} onMouseEnter={() => this._onMouseEnter(r.room)}
onMouseLeave={() => this._onMouseLeave(r.room)} onMouseLeave={() => this._onMouseLeave(r.room)}
aria-label={_t("Room %(name)s", {name: r.room.name})} aria-label={_t("Room %(name)s", {name: r.room.name})}
role="listitem"
> >
<RoomAvatar room={r.room} width={32} height={32} /> <RoomAvatar room={r.room} width={32} height={32} />
{badge} {badge}
@ -363,7 +362,7 @@ export default class RoomBreadcrumbs extends React.Component {
); );
}); });
return ( return (
<div role="list" aria-orientation="horizontal" aria-roledescription={_t("Recent rooms")}> <div role="toolbar" aria-label={_t("Recent rooms")}>
<IndicatorScrollbar <IndicatorScrollbar
ref="scroller" ref="scroller"
className="mx_RoomBreadcrumbs" className="mx_RoomBreadcrumbs"