Matrix/element-web-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2024-11-16 21:24:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove React warning

Browse Source 
Fire onOptionChange in componentWillMount, otherwise end up trying
to update state effectively in a render method, which is bad.
This commit is contained in:
David Baker 2017-03-29 15:05:49 +01:00
parent 6f4b080934
commit e139f5212a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/views/login/CountryDropdown.js
View File

@ -43,8 +43,10 @@ export default class CountryDropdown extends React.Component {
this.state = {
searchQuery: '',
}
}
if (!props.value) {
componentWillMount() {
if (!this.props.value) {
// If no value is given, we start with the first
// country selected, but our parent component
// doesn't know this, therefore we do this.