Matrix/element-web-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2024-11-17 22:14:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #64 from matrix-org/rav/fix_date_separator

Browse Source 
Fix bug with date separator flashing up on scrollback
This commit is contained in:
Richard van der Hoff 2015-12-22 11:05:26 +00:00
commit cc90f4c0c6
1 changed files with 33 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
src/components/structures/RoomView.js
View File

@ -399,6 +399,12 @@ module.exports = React.createClass({
} }
}, },
// return true if there's more messages in the backlog which we aren't displaying
_canPaginate: function() {
return (this.state.messageCap < this.state.room.timeline.length) ||
this.state.room.oldState.paginationToken;
},
onResendAllClick: function() { onResendAllClick: function() {
var eventsToResend = this._getUnsentMessages(this.state.room); var eventsToResend = this._getUnsentMessages(this.state.room);
eventsToResend.forEach(function(event) { eventsToResend.forEach(function(event) {
@ -697,7 +703,10 @@ module.exports = React.createClass({
return ret; return ret;
} }
for (var i = this.state.room.timeline.length-1; i >= 0 && count < this.state.messageCap; --i) {
var prevEvent = null; // the last event we showed
var startIdx = Math.max(0, this.state.room.timeline.length - this.state.messageCap);
for (var i = startIdx; i < this.state.room.timeline.length; i++) {
var mxEv = this.state.room.timeline[i]; var mxEv = this.state.room.timeline[i];
if (!EventTile.haveTileForEvent(mxEv)) { if (!EventTile.haveTileForEvent(mxEv)) {
@ -710,49 +719,45 @@ module.exports = React.createClass({
} }
} }
// is this a continuation of the previous message?
var continuation = false; var continuation = false;
var last = false; if (prevEvent !== null) {
var dateSeparator = null; if (mxEv.sender &&
if (i == this.state.room.timeline.length - 1) { prevEvent.sender &&
last = true; (mxEv.sender.userId === prevEvent.sender.userId) &&
} (mxEv.getType() == prevEvent.getType())
if (i > 0 && count < this.state.messageCap - 1) {
if (this.state.room.timeline[i].sender &&
this.state.room.timeline[i - 1].sender &&
(this.state.room.timeline[i].sender.userId ===
this.state.room.timeline[i - 1].sender.userId) &&
(this.state.room.timeline[i].getType() ==
this.state.room.timeline[i - 1].getType())
) )
{ {
continuation = true; continuation = true;
} }
var ts0 = this.state.room.timeline[i - 1].getTs();
var ts1 = this.state.room.timeline[i].getTs();
if (new Date(ts0).toDateString() !== new Date(ts1).toDateString()) {
dateSeparator = <li key={ts1}><DateSeparator key={ts1} ts={ts1}/></li>;
continuation = false;
}
} }
if (i === 1) { // n.b. 1, not 0, as the 0th event is an m.room.create and so doesn't show on the timeline // do we need a date separator since the last event?
var ts1 = this.state.room.timeline[i].getTs(); var ts1 = mxEv.getTs();
dateSeparator = <li key={ts1}><DateSeparator ts={ts1}/></li>; if ((prevEvent == null && !this._canPaginate()) ||
(prevEvent != null &&
new Date(prevEvent.getTs()).toDateString() !== new Date(ts1).toDateString())) {
var dateSeparator = <li key={ts1}><DateSeparator key={ts1} ts={ts1}/></li>;
ret.push(dateSeparator);
continuation = false; continuation = false;
} }
var last = false;
if (i == this.state.room.timeline.length - 1) {
// XXX: we might not show a tile for the last event.
last = true;
}
var eventId = mxEv.getId(); var eventId = mxEv.getId();
ret.unshift( ret.push(
<li key={eventId} ref={this._collectEventNode.bind(this, eventId)} data-scroll-token={eventId}> <li key={eventId} ref={this._collectEventNode.bind(this, eventId)} data-scroll-token={eventId}>
<EventTile mxEvent={mxEv} continuation={continuation} last={last}/> <EventTile mxEvent={mxEv} continuation={continuation} last={last}/>
</li> </li>
); );
if (dateSeparator) {
ret.unshift(dateSeparator); prevEvent = mxEv;
}
++count;
} }
return ret; return ret;
}, },