From a6e98b0b6340c7782cf4d7f5c5370f23fea9ca84 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Fri, 13 Sep 2024 12:09:41 +0100 Subject: [PATCH] Use `strong` over `b` for improved a11y semantics Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- res/css/views/auth/_AuthBody.pcss | 2 +- src/IdentityAuthClient.tsx | 2 +- src/RoomInvite.tsx | 2 +- .../auth/forgot-password/CheckEmail.tsx | 2 +- .../auth/forgot-password/EnterEmail.tsx | 2 +- .../auth/forgot-password/VerifyEmailModal.tsx | 2 +- .../auth/InteractiveAuthEntryComponents.tsx | 2 +- src/components/views/auth/LoginWithQRFlow.tsx | 2 +- .../dialogs/AnalyticsLearnMoreDialog.tsx | 4 ++-- .../views/dialogs/BugReportDialog.tsx | 6 ++--- .../views/dialogs/CreateRoomDialog.tsx | 8 +++++-- .../views/dialogs/CreateSubspaceDialog.tsx | 4 ++-- .../views/dialogs/LeaveSpaceDialog.tsx | 2 +- .../ManageRestrictedJoinRuleDialog.tsx | 2 +- .../ManualDeviceKeyVerificationDialog.tsx | 2 +- .../dialogs/RegistrationEmailPromptDialog.tsx | 2 +- .../dialogs/RoomUpgradeWarningDialog.tsx | 2 +- .../views/dialogs/UploadFailureDialog.tsx | 6 ++--- .../dialogs/devtools/SettingExplorer.tsx | 2 +- .../security/RestoreKeyBackupDialog.tsx | 8 +++++-- src/components/views/rooms/NewRoomIntro.tsx | 4 ++-- .../views/rooms/RoomPreviewCard.tsx | 2 +- .../views/rooms/RoomSearchAuxPanel.tsx | 2 +- .../views/rooms/RoomUpgradeWarningBar.tsx | 2 +- .../views/settings/CryptographyPanel.tsx | 2 +- .../views/settings/JoinRuleSettings.tsx | 4 ++-- .../views/settings/SecureBackupPanel.tsx | 8 +++++-- src/components/views/settings/SetIdServer.tsx | 14 +++++------ .../views/settings/SetIntegrationManager.tsx | 2 +- .../tabs/room/AdvancedRoomSettingsTab.tsx | 2 +- .../tabs/room/SecurityRoomSettingsTab.tsx | 4 ++-- .../tabs/user/HelpUserSettingsTab.tsx | 2 +- .../spaces/SpaceSettingsVisibilityTab.tsx | 4 +++- src/utils/exportUtils/HtmlExport.tsx | 6 ++--- src/widgets/CapabilityText.tsx | 24 +++++++++---------- 35 files changed, 80 insertions(+), 66 deletions(-) diff --git a/res/css/views/auth/_AuthBody.pcss b/res/css/views/auth/_AuthBody.pcss index de2052cc82..6a7082fc87 100644 --- a/res/css/views/auth/_AuthBody.pcss +++ b/res/css/views/auth/_AuthBody.pcss @@ -16,7 +16,7 @@ Please see LICENSE files in the repository root for full details. padding: 25px 60px; box-sizing: border-box; - b { + strong { font-weight: var(--cpd-font-weight-semibold); } diff --git a/src/IdentityAuthClient.tsx b/src/IdentityAuthClient.tsx index 6a3a1b081d..3b78d9e570 100644 --- a/src/IdentityAuthClient.tsx +++ b/src/IdentityAuthClient.tsx @@ -141,7 +141,7 @@ export default class IdentityAuthClient { "terms|identity_server_no_terms_description_1", {}, { - server: () => {abbreviateUrl(identityServerUrl)}, + server: () => {abbreviateUrl(identityServerUrl)}, }, )}
diff --git a/src/RoomInvite.tsx b/src/RoomInvite.tsx index c4ab2c506f..d4f156c91d 100644 --- a/src/RoomInvite.tsx +++ b/src/RoomInvite.tsx @@ -145,7 +145,7 @@ export function showAnyInviteErrors( "invite|room_failed_partial", {}, { - RoomName: () => {room.name}, + RoomName: () => {room.name}, }, )} diff --git a/src/components/structures/auth/forgot-password/CheckEmail.tsx b/src/components/structures/auth/forgot-password/CheckEmail.tsx index 77127df5fa..af563a8fa2 100644 --- a/src/components/structures/auth/forgot-password/CheckEmail.tsx +++ b/src/components/structures/auth/forgot-password/CheckEmail.tsx @@ -46,7 +46,7 @@ export const CheckEmail: React.FC{_t("auth|check_email_explainer", { email: email }, { b: (t) => {t} })}
+{_t("auth|check_email_explainer", { email: email }, { b: (t) => {t} })}
- {_t("auth|enter_email_explainer", { homeserver }, { b: (t) => {t} })} + {_t("auth|enter_email_explainer", { homeserver }, { b: (t) => {t} })}
- {_t("bug_reporting|unsupported_browser")} + {_t("bug_reporting|unsupported_browser")}
); } @@ -221,7 +221,7 @@ export default class BugReportDialog extends React.Component{_t("bug_reporting|description")}
-
+
{_t(
"bug_reporting|before_submitting",
{},
@@ -237,7 +237,7 @@ export default class BugReportDialog extends React.Component
- {key}
+ {key}
diff --git a/src/components/views/dialogs/RegistrationEmailPromptDialog.tsx b/src/components/views/dialogs/RegistrationEmailPromptDialog.tsx
index ffaf01189b..a02098d3ed 100644
--- a/src/components/views/dialogs/RegistrationEmailPromptDialog.tsx
+++ b/src/components/views/dialogs/RegistrationEmailPromptDialog.tsx
@@ -54,7 +54,7 @@ const RegistrationEmailPromptDialog: React.FC{_t("restore_key_backup_dialog|key_backup_warning", {}, { b: (sub) => {sub} })}
++ {_t("restore_key_backup_dialog|key_backup_warning", {}, { b: (sub) => {sub} })} +
{_t("restore_key_backup_dialog|enter_phrase_description")}
{roomId}
-
+
);
}
},
@@ -209,7 +209,7 @@ export class CapabilityText {
eventType: eventCap.eventType,
},
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
),
byline: CapabilityText.bylineFor(eventCap),
@@ -222,7 +222,7 @@ export class CapabilityText {
eventType: eventCap.eventType,
},
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
),
byline: CapabilityText.bylineFor(eventCap),
@@ -238,7 +238,7 @@ export class CapabilityText {
eventType: eventCap.eventType,
},
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
),
byline: CapabilityText.bylineFor(eventCap),
@@ -251,7 +251,7 @@ export class CapabilityText {
eventType: eventCap.eventType,
},
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
),
byline: CapabilityText.bylineFor(eventCap),
@@ -266,7 +266,7 @@ export class CapabilityText {
"widget|capability|capability",
{ capability },
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
),
};
@@ -390,7 +390,7 @@ export class CapabilityText {
msgtype: eventCap.keyStr,
},
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
);
} else {
@@ -400,7 +400,7 @@ export class CapabilityText {
msgtype: eventCap.keyStr,
},
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
);
}
@@ -412,7 +412,7 @@ export class CapabilityText {
msgtype: eventCap.keyStr,
},
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
);
} else {
@@ -422,7 +422,7 @@ export class CapabilityText {
msgtype: eventCap.keyStr,
},
{
- b: (sub) => {sub},
+ b: (sub) => {sub},
},
);
}