Matrix/element-web-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2024-11-17 05:55:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2882 from matrix-org/travis/permalink-explosion

Browse Source 
Prevent the permalink creator from causing cascading failure
This commit is contained in:
Travis Ralston 2019-04-08 06:56:13 -06:00 committed by GitHub
commit a53d9f59fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/matrix-to.js
View File

@ -83,6 +83,14 @@ export class RoomPermalinkCreator {
}
load() {
if (!this._room || !this._room.currentState) {
// Under rare and unknown circumstances it is possible to have a room with no
// currentState, at least potentially at the early stages of joining a room.
// To avoid breaking everything, we'll just warn rather than throw as well as
// not bother updating the various aspects of the share link.
console.warn("Tried to load a permalink creator with no room state");
return;
}
this._updateAllowedServers();
this._updateHighestPlUser();
this._updatePopulationMap();