PR feedback

This commit is contained in:
David Baker 2017-08-30 09:22:26 +01:00
parent d86fe0df6e
commit 824b29dc1f
2 changed files with 4 additions and 3 deletions

View File

@ -78,7 +78,7 @@ module.exports = withMatrixClient(React.createClass({
// return to the user list // return to the user list
dis.dispatch({ dis.dispatch({
action: "view_user", action: "view_user",
groupMember: null, member: null,
}); });
}).catch((e) => { }).catch((e) => {
const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
@ -97,7 +97,7 @@ module.exports = withMatrixClient(React.createClass({
// Go back to the user list // Go back to the user list
dis.dispatch({ dis.dispatch({
action: "view_user", action: "view_user",
groupMember: null, member: null,
}); });
}, },
@ -116,7 +116,7 @@ module.exports = withMatrixClient(React.createClass({
if (!this.state.groupMembers) return null; if (!this.state.groupMembers) return null;
const targetIsInGroup = this.state.groupMembers.some((m) => { const targetIsInGroup = this.state.groupMembers.some((m) => {
return m.userId == this.props.groupMember.userId; return m.userId === this.props.groupMember.userId;
}); });
let kickButton; let kickButton;

View File

@ -90,6 +90,7 @@ export default withMatrixClient(React.createClass({
let memberList = this.state.members; let memberList = this.state.members;
if (query) { if (query) {
memberList = memberList.filter((m) => { memberList = memberList.filter((m) => {
// TODO: add this when we have this info from the API
//const matchesName = m.name.toLowerCase().indexOf(query) !== -1; //const matchesName = m.name.toLowerCase().indexOf(query) !== -1;
const matchesId = m.userId.toLowerCase().includes(query); const matchesId = m.userId.toLowerCase().includes(query);