From 824b29dc1fd536dd180f9bea2ef76351a555aac9 Mon Sep 17 00:00:00 2001 From: David Baker Date: Wed, 30 Aug 2017 09:22:26 +0100 Subject: [PATCH] PR feedback --- src/components/views/groups/GroupMemberInfo.js | 6 +++--- src/components/views/groups/GroupMemberList.js | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/components/views/groups/GroupMemberInfo.js b/src/components/views/groups/GroupMemberInfo.js index bd8eb667e0..5495a9bd71 100644 --- a/src/components/views/groups/GroupMemberInfo.js +++ b/src/components/views/groups/GroupMemberInfo.js @@ -78,7 +78,7 @@ module.exports = withMatrixClient(React.createClass({ // return to the user list dis.dispatch({ action: "view_user", - groupMember: null, + member: null, }); }).catch((e) => { const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); @@ -97,7 +97,7 @@ module.exports = withMatrixClient(React.createClass({ // Go back to the user list dis.dispatch({ action: "view_user", - groupMember: null, + member: null, }); }, @@ -116,7 +116,7 @@ module.exports = withMatrixClient(React.createClass({ if (!this.state.groupMembers) return null; const targetIsInGroup = this.state.groupMembers.some((m) => { - return m.userId == this.props.groupMember.userId; + return m.userId === this.props.groupMember.userId; }); let kickButton; diff --git a/src/components/views/groups/GroupMemberList.js b/src/components/views/groups/GroupMemberList.js index 32a9e2ca52..85e17a5bb3 100644 --- a/src/components/views/groups/GroupMemberList.js +++ b/src/components/views/groups/GroupMemberList.js @@ -90,6 +90,7 @@ export default withMatrixClient(React.createClass({ let memberList = this.state.members; if (query) { memberList = memberList.filter((m) => { + // TODO: add this when we have this info from the API //const matchesName = m.name.toLowerCase().indexOf(query) !== -1; const matchesId = m.userId.toLowerCase().includes(query);