Matrix/element-web-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2024-11-15 04:34:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential racy dangling listener

Browse Source
This commit is contained in:
Florian Duros 2024-10-23 16:10:33 +02:00
parent 0ba08404f5
commit 7507e3cb9a
No known key found for this signature in database
GPG Key ID: A5BBB4041B493F15
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/components/structures/FilePanel.tsx
View File

@ -62,6 +62,8 @@ class FilePanel extends React.Component<IProps, IState> {
private decryptingEvents = new Set<string>();
public noRoom = false;
private card = createRef<HTMLDivElement>();
// This is used to track if the component is unmounting to avoid adding dangling listeners
private isUnloading = false;
public state: IState = {
timelineSet: null,
@ -133,13 +135,16 @@ class FilePanel extends React.Component<IProps, IState> {
// We do this only for encrypted rooms and if an event index exists,
// this could be made more general in the future or the filter logic
// could be fixed.
if (EventIndexPeg.get() !== null) {
//
// `componentDidMount` is async and we need to be sure to not put this listener when the component is unmount before the mounting is done.
if (EventIndexPeg.get() !== null && this.isUnloading) {
client.on(RoomEvent.Timeline, this.onRoomTimeline);
client.on(MatrixEventEvent.Decrypted, this.onEventDecrypted);
}
}
public componentWillUnmount(): void {
this.isUnloading = true;
const client = MatrixClientPeg.get();
if (client === null || !this.state.isRoomEncrypted) return;