Matrix/element-web-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2024-11-15 20:54:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Convert enzyme to rtl: RightPanel (#9837)

Browse Source
This commit is contained in:
alunturner 2022-12-29 08:40:42 +00:00 committed by GitHub
parent c0ba1b8a1c
commit 49fefb0c32
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
test/components/structures/RightPanel-test.tsx
View File

@ -16,7 +16,8 @@ limitations under the License.
import React from "react"; import React from "react";
// eslint-disable-next-line deprecate/import // eslint-disable-next-line deprecate/import
import { mount } from "enzyme"; import { render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { jest } from "@jest/globals"; import { jest } from "@jest/globals";
import { mocked, MockedObject } from "jest-mock"; import { mocked, MockedObject } from "jest-mock";
import { MatrixClient } from "matrix-js-sdk/src/client"; import { MatrixClient } from "matrix-js-sdk/src/client";
@ -33,8 +34,6 @@ import { RightPanelPhases } from "../../../src/stores/right-panel/RightPanelStor
import RightPanelStore from "../../../src/stores/right-panel/RightPanelStore"; import RightPanelStore from "../../../src/stores/right-panel/RightPanelStore";
import { UPDATE_EVENT } from "../../../src/stores/AsyncStore"; import { UPDATE_EVENT } from "../../../src/stores/AsyncStore";
import { WidgetLayoutStore } from "../../../src/stores/widgets/WidgetLayoutStore"; import { WidgetLayoutStore } from "../../../src/stores/widgets/WidgetLayoutStore";
import RoomSummaryCard from "../../../src/components/views/right_panel/RoomSummaryCard";
import MemberList from "../../../src/components/views/rooms/MemberList";
import { SdkContextClass } from "../../../src/contexts/SDKContext"; import { SdkContextClass } from "../../../src/contexts/SDKContext";
const RightPanelBase = wrapInMatrixClientContext(_RightPanel); const RightPanelBase = wrapInMatrixClientContext(_RightPanel);
@ -111,15 +110,14 @@ describe("RightPanel", () => {
}); });
await viewedRoom; await viewedRoom;
const wrapper = mount(<RightPanel room={r1} resizeNotifier={resizeNotifier} />); const { container } = render(<RightPanel room={r1} resizeNotifier={resizeNotifier} />);
expect(wrapper.find(RoomSummaryCard).exists()).toEqual(true); expect(container.getElementsByClassName("mx_RoomSummaryCard")).toHaveLength(1);
const switchedPhases = waitForRpsUpdate(); const switchedPhases = waitForRpsUpdate();
wrapper.find("AccessibleButton.mx_RoomSummaryCard_icon_people").simulate("click"); userEvent.click(screen.getByText(/people/i));
await switchedPhases; await switchedPhases;
wrapper.update();
expect(wrapper.find(MemberList).exists()).toEqual(true); expect(container.getElementsByClassName("mx_MemberList")).toHaveLength(1);
}); });
it("renders info from only one room during room changes", async () => { it("renders info from only one room during room changes", async () => {
@ -154,7 +152,7 @@ describe("RightPanel", () => {
await spinUpStores(); await spinUpStores();
// Run initial render with room 1, and also running lifecycle methods // Run initial render with room 1, and also running lifecycle methods
const wrapper = mount(<RightPanel room={r1} resizeNotifier={resizeNotifier} />); const { container, rerender } = render(<RightPanel room={r1} resizeNotifier={resizeNotifier} />);
// Wait for RPS room 1 updates to fire // Wait for RPS room 1 updates to fire
const rpsUpdated = waitForRpsUpdate(); const rpsUpdated = waitForRpsUpdate();
dis.dispatch({ dis.dispatch({
@ -162,31 +160,26 @@ describe("RightPanel", () => {
room_id: "r1", room_id: "r1",
}); });
await rpsUpdated; await rpsUpdated;
await waitFor(() => expect(screen.queryByTestId("spinner")).not.toBeInTheDocument());
// After all that setup, now to the interesting part... // room one will be in the RoomMemberList phase - confirm this is rendered
// We want to verify that as we change to room 2, we should always have expect(container.getElementsByClassName("mx_MemberList")).toHaveLength(1);
// the correct right panel state for whichever room we are showing.
const instance = wrapper.find(_RightPanel).instance() as _RightPanel;
const rendered = new Promise<void>((resolve) => {
jest.spyOn(instance, "render").mockImplementation(() => {
const { props, state } = instance;
if (props.room.roomId === "r2" && state.phase === RightPanelPhases.RoomMemberList) {
throw new Error("Tried to render room 1 state for room 2");
}
if (props.room.roomId === "r2" && state.phase === RightPanelPhases.RoomSummary) {
resolve();
}
return null;
});
});
// Switch to room 2 // wait for RPS room 2 updates to fire, then rerender
const _rpsUpdated = waitForRpsUpdate();
dis.dispatch({ dis.dispatch({
action: Action.ViewRoom, action: Action.ViewRoom,
room_id: "r2", room_id: "r2",
}); });
wrapper.setProps({ room: r2 }); await _rpsUpdated;
rerender(<RightPanel room={r2} resizeNotifier={resizeNotifier} />);
await rendered; // After all that setup, now to the interesting part...
// We want to verify that as we change to room 2, we should always have
// the correct right panel state for whichever room we are showing, so we
// confirm we do not have the MemberList class on the page and that we have
// the expected room title
expect(container.getElementsByClassName("mx_MemberList")).toHaveLength(0);
expect(screen.getByRole("heading", { name: "r2" })).toBeInTheDocument();
}); });
}); });