diff --git a/src/components/views/messages/RoomCreate.js b/src/components/views/messages/RoomCreate.js index 268acc935c..6098b1217e 100644 --- a/src/components/views/messages/RoomCreate.js +++ b/src/components/views/messages/RoomCreate.js @@ -22,7 +22,6 @@ import dis from '../../../dispatcher/dispatcher'; import { RoomPermalinkCreator } from '../../../utils/permalinks/Permalinks'; import { _t } from '../../../languageHandler'; import {MatrixClientPeg} from '../../../MatrixClientPeg'; -import ViewSourceEvent from "./ViewSourceEvent"; export default class RoomCreate extends React.Component { static propTypes = { @@ -46,8 +45,7 @@ export default class RoomCreate extends React.Component { render() { const predecessor = this.props.mxEvent.getContent()['predecessor']; if (predecessor === undefined) { - // We would never have been instantiated in this case except if user has showHiddenEventsInTimeline enabled - return ; + return
; // We should never have been instantiated in this case } const prevRoom = MatrixClientPeg.get().getRoom(predecessor['room_id']); const permalinkCreator = new RoomPermalinkCreator(prevRoom, predecessor['room_id']); diff --git a/src/components/views/rooms/EventTile.js b/src/components/views/rooms/EventTile.js index c2b1af2ddc..01646ad567 100644 --- a/src/components/views/rooms/EventTile.js +++ b/src/components/views/rooms/EventTile.js @@ -657,8 +657,7 @@ export default class EventTile extends React.Component { // source tile when there's no regular tile for an event and also for // replace relations (which otherwise would display as a confusing // duplicate of the thing they are replacing). - const useSource = !tileHandler || this.props.mxEvent.isRelation("m.replace"); - if (useSource && SettingsStore.getValue("showHiddenEventsInTimeline")) { + if (SettingsStore.getValue("showHiddenEventsInTimeline") && !haveTileForEvent(this.props.mxEvent)) { tileHandler = "messages.ViewSourceEvent"; // Reuse info message avatar and sender profile styling isInfoMessage = true;