Matrix/element-web-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2024-11-16 21:24:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

exclude chrome in ua from safari version check for colr support

Browse Source
This commit is contained in:
Bruno Windels 2019-05-29 13:05:59 +02:00
parent f61e771f7a
commit 26a5bb0dcb
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/utils/FontManager.js
View File

@ -22,6 +22,7 @@ limitations under the License.
*/ */
function safariVersionCheck(ua) { function safariVersionCheck(ua) {
console.log("Browser is Safari - checking version for COLR support");
try { try {
const safariVersionMatch = ua.match(/Mac OS X ([\d|_]+).*Version\/([\d|.]+).*Safari/); const safariVersionMatch = ua.match(/Mac OS X ([\d|_]+).*Version\/([\d|.]+).*Safari/);
if (safariVersionMatch) { if (safariVersionMatch) {
@ -31,7 +32,7 @@ function safariVersionCheck(ua) {
const safariVersion = safariVersionStr.split(".").map(n => parseInt(n, 10)); const safariVersion = safariVersionStr.split(".").map(n => parseInt(n, 10));
const colrFontSupported = macOSVersion[0] >= 10 && macOSVersion[1] >= 14 && safariVersion[0] >= 12; const colrFontSupported = macOSVersion[0] >= 10 && macOSVersion[1] >= 14 && safariVersion[0] >= 12;
// https://www.colorfonts.wtf/ states safari supports COLR fonts from this version on // https://www.colorfonts.wtf/ states safari supports COLR fonts from this version on
console.log(`Browser is Safari - requiring macOS 10.14 and Safari 12, ` + console.log(`COLR support on Safari requires macOS 10.14 and Safari 12, ` +
`detected Safari ${safariVersionStr} on macOS ${macOSVersionStr}, ` + `detected Safari ${safariVersionStr} on macOS ${macOSVersionStr}, ` +
`COLR supported: ${colrFontSupported}`); `COLR supported: ${colrFontSupported}`);
return colrFontSupported; return colrFontSupported;
@ -45,19 +46,21 @@ function safariVersionCheck(ua) {
async function isColrFontSupported() { async function isColrFontSupported() {
console.log("Checking for COLR support"); console.log("Checking for COLR support");
const {userAgent} = navigator;
// Firefox has supported COLR fonts since version 26 // Firefox has supported COLR fonts since version 26
// but doesn't support the check below without // but doesn't support the check below without
// "Extract canvas data" permissions // "Extract canvas data" permissions
// when content blocking is enabled. // when content blocking is enabled.
if (navigator.userAgent.includes("Firefox")) { if (userAgent.includes("Firefox")) {
console.log("Browser is Firefox - assuming COLR is supported"); console.log("Browser is Firefox - assuming COLR is supported");
return true; return true;
} }
// Safari doesn't wait for the font to load (if it doesn't have it in cache) // Safari doesn't wait for the font to load (if it doesn't have it in cache)
// to emit the load event on the image, so there is no way to not make the check // to emit the load event on the image, so there is no way to not make the check
// reliable. Instead sniff the version. // reliable. Instead sniff the version.
if (navigator.userAgent.includes("Safari")) { // Excluding "Chrome", as it's user agent unhelpfully also contains Safari...
return safariVersionCheck(navigator.userAgent); if (!userAgent.includes("Chrome") && userAgent.includes("Safari")) {
return safariVersionCheck(userAgent);
} }
try { try {