From 48299bb1545e8dfebcba717ff6e1e735df7adf45 Mon Sep 17 00:00:00 2001 From: Bruno Windels Date: Mon, 8 Oct 2018 15:28:00 +0200 Subject: [PATCH] show warning when LL is disabled but was enabled before --- src/Lifecycle.js | 13 +++++++ .../dialogs/LazyLoadingDisabledDialog.js | 39 +++++++++++++++++++ src/i18n/strings/en_EN.json | 6 ++- 3 files changed, 57 insertions(+), 1 deletion(-) create mode 100644 src/components/views/dialogs/LazyLoadingDisabledDialog.js diff --git a/src/Lifecycle.js b/src/Lifecycle.js index 434975a5bc..b3178710a1 100644 --- a/src/Lifecycle.js +++ b/src/Lifecycle.js @@ -250,6 +250,19 @@ function _handleLoadSessionFailure(e) { onFinished: resolve, }); }); + } else { + // show warning about simultaneous use + // between LL/non-LL version on same host. + // as disabling LL when previously enabled + // is a strong indicator of this (/develop & /app) + const LazyLoadingDisabledDialog = + sdk.getComponent("views.dialogs.LazyLoadingDisabledDialog"); + return new Promise((resolve) => { + Modal.createDialog(LazyLoadingDisabledDialog, { + onFinished: resolve, + host: window.location.host, + }); + }); } }).then(() => { return MatrixClientPeg.get().store.deleteAllData(); diff --git a/src/components/views/dialogs/LazyLoadingDisabledDialog.js b/src/components/views/dialogs/LazyLoadingDisabledDialog.js new file mode 100644 index 0000000000..d128d8dedd --- /dev/null +++ b/src/components/views/dialogs/LazyLoadingDisabledDialog.js @@ -0,0 +1,39 @@ +/* +Copyright 2018 New Vector Ltd + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +import React from 'react'; +import QuestionDialog from './QuestionDialog'; +import { _t } from '../../../languageHandler'; + +export default (props) => { + const description1 = + _t("You've previously used Riot on %(host)s with lazy loading of members enabled. " + + "In this version lazy loading is disabled. " + + "As the local cache is not compatible between these two settings, " + + "Riot needs to resync your account.", + {host: props.host}); + const description2 = _t("If the other version of Riot is still open in another tab, " + + "please close it as using Riot on the same host with both " + + "lazy loading enabled and disabled simultaneously will cause issues."); + + return (

{description1}

{description2}

} + button={_t("Clear cache and resync")} + onFinished={props.onFinished} + />); +}; diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index 5ec6a7c1ff..338f744a9f 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1261,5 +1261,9 @@ "Import": "Import", "Failed to set direct chat tag": "Failed to set direct chat tag", "Failed to remove tag %(tagName)s from room": "Failed to remove tag %(tagName)s from room", - "Failed to add tag %(tagName)s to room": "Failed to add tag %(tagName)s to room" + "Failed to add tag %(tagName)s to room": "Failed to add tag %(tagName)s to room", + "You've previously used Riot on %(host)s with lazy loading of members enabled. In this version lazy loading is disabled. As the local cache is not compatible between these two settings, Riot needs to resync your account.": "You've previously used Riot on %(host)s with lazy loading of members enabled. In this version lazy loading is disabled. As the local cache is not compatible between these two settings, Riot needs to resync your account.", + "If the other version of Riot is still open in another tab, please close it as using Riot on the same host with both lazy loading enabled and disabled simultaneously will cause issues.": "If the other version of Riot is still open in another tab, please close it as using Riot on the same host with both lazy loading enabled and disabled simultaneously will cause issues.", + "Incompatible local cache": "Incompatible local cache", + "Clear cache and resync": "Clear cache and resync" }