Matrix/element-web-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-web.git synced 2024-11-16 21:24:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6942 from SimonBrandner/fix/autoplay-setting

Browse Source 
Don't `setValue()` if that would lead to setting a `null`/`undefined`
This commit is contained in:
James Salter 2021-10-14 09:30:43 +01:00 committed by GitHub
commit 1f7d07ab6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/settings/handlers/AccountSettingsHandler.ts
View File

@ -118,8 +118,10 @@ export default class AccountSettingsHandler extends MatrixClientBackedSettingsHa
if (value === null || value === undefined) { if (value === null || value === undefined) {
const oldCombinedValue = settings["autoplayGifsAndVideos"]; const oldCombinedValue = settings["autoplayGifsAndVideos"];
// Write, so that we can remove this in the future // Write, so that we can remove this in the future
this.setValue("autoplayGifs", roomId, oldCombinedValue); if (oldCombinedValue !== null && oldCombinedValue !== undefined) {
this.setValue("autoplayVideo", roomId, oldCombinedValue); this.setValue("autoplayGifs", roomId, oldCombinedValue);
this.setValue("autoplayVideo", roomId, oldCombinedValue);
}
return oldCombinedValue; return oldCombinedValue;
} }
return value; return value;