element-web-Github/test/unit-tests/autocomplete/EmojiProvider-test.ts

91 lines
3.5 KiB
TypeScript
Raw Normal View History

Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
/*
Copyright 2024 New Vector Ltd.
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
Copyright 2022 Ryan Browne <code@commonlawfeature.com>
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only
Please see LICENSE files in the repository root for full details.
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
*/
import EmojiProvider from "../../../src/autocomplete/EmojiProvider";
import { mkStubRoom } from "../../test-utils/test-utils";
import { add } from "../../../src/emojipicker/recent";
import { stubClient } from "../../test-utils";
import { MatrixClientPeg } from "../../../src/MatrixClientPeg";
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
const EMOJI_SHORTCODES = [
":+1",
":heart",
":grinning",
":hand",
":man",
":sweat",
":monkey",
":boat",
":mailbox",
":cop",
":bow",
":kiss",
":golf",
];
// Some emoji shortcodes are too short and do not actually trigger autocompletion until the ending `:`.
// This means that we cannot compare their autocompletion before and after the ending `:` and have
// to simply assert that the final completion with the colon is the exact emoji.
2022-12-12 19:24:14 +08:00
const TOO_SHORT_EMOJI_SHORTCODE = [{ emojiShortcode: ":o", expectedEmoji: "⭕️" }];
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
2022-12-12 19:24:14 +08:00
describe("EmojiProvider", function () {
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
const testRoom = mkStubRoom(undefined, undefined, undefined);
stubClient();
MatrixClientPeg.safeGet();
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
2022-12-12 19:24:14 +08:00
it.each(EMOJI_SHORTCODES)("Returns consistent results after final colon %s", async function (emojiShortcode) {
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
const ep = new EmojiProvider(testRoom);
2022-12-12 19:24:14 +08:00
const range = { beginning: true, start: 0, end: 3 };
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
const completionsBeforeColon = await ep.getCompletions(emojiShortcode, range);
2022-12-12 19:24:14 +08:00
const completionsAfterColon = await ep.getCompletions(emojiShortcode + ":", range);
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
const firstCompletionWithoutColon = completionsBeforeColon[0].completion;
const firstCompletionWithColon = completionsAfterColon[0].completion;
expect(firstCompletionWithoutColon).toEqual(firstCompletionWithColon);
});
2022-12-12 19:24:14 +08:00
it.each(TOO_SHORT_EMOJI_SHORTCODE)(
"Returns correct results after final colon $emojiShortcode",
async ({ emojiShortcode, expectedEmoji }) => {
const ep = new EmojiProvider(testRoom);
const range = { beginning: true, start: 0, end: 3 };
const completions = await ep.getCompletions(emojiShortcode + ":", range);
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
2022-12-12 19:24:14 +08:00
expect(completions[0].completion).toEqual(expectedEmoji);
},
);
it("Recently used emojis are correctly sorted", async function () {
add("😘"); //kissing_heart
add("💗"); //heartpulse
add("💗"); //heartpulse
add("😍"); //heart_eyes
const ep = new EmojiProvider(testRoom);
const completionsList = await ep.getCompletions(":heart", { beginning: true, start: 0, end: 6 });
expect(completionsList[0]?.component?.props.title).toEqual(":heartpulse:");
expect(completionsList[1]?.component?.props.title).toEqual(":heart_eyes:");
});
it("Exact match in recently used takes the lead", async function () {
add("😘"); //kissing_heart
add("💗"); //heartpulse
add("💗"); //heartpulse
add("😍"); //heart_eyes
add("❤️"); //heart
const ep = new EmojiProvider(testRoom);
const completionsList = await ep.getCompletions(":heart", { beginning: true, start: 0, end: 6 });
expect(completionsList[0]?.component?.props.title).toEqual(":heart:");
expect(completionsList[1]?.component?.props.title).toEqual(":heartpulse:");
expect(completionsList[2]?.component?.props.title).toEqual(":heart_eyes:");
});
Resolve emoji autocomplete not being temporally consistent (#8086) * Adds a test to demonstrate the issue with emoji autocomplete reported in https://github.com/vector-im/element-web/issues/19302. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Trim trailing `:` when checking for autocompletes for emoji. Closes https://github.com/vector-im/element-web/issues/19302 Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Move all references to the emoji delimiter character to reference a constant. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Move all references to the emoji delimiter character to reference a constant." This reverts commit ac09e71e4c6151e35d21f612c9b329ead2a381f1. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Rename variable. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Make the test file a .js file. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Update quotes to match style and make a valid stubbed room. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Fix variable name and test reporting. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use str.replace with a regex. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters. Signed-off-by: Ryan Browne <code@commonlawfeature.com> * Revert "Use an improved regex that does not have have to iterate through the entire string, and can just backtrack at most the last 2 characters." This regex is very efficient, but requires a specific form of the emoji shortcode that it is not clear is within our control. This is a restriction that is not required by the technicalities of solving the bug this PR is attempting to fix. (It requires that an emoji shortcode end with a colon.) This reverts commit 220cb0efb8de247158c11daf9170464a57cc3af2. Signed-off-by: Ryan Browne <code@commonlawfeature.com> Co-authored-by: Ryan Browne <code@commonlawfeature.com>
2022-04-15 04:31:50 +08:00
});