mirror of
https://github.com/vector-im/element-call.git
synced 2024-11-27 00:48:06 +08:00
169ccd9de5
As Element Call grows in complexity, it has become a pain point that our business logic remains so tightly coupled to the UI code. In particular, this has made testing difficult, and the complex semantics of React hooks are not a great match for arbitrary business logic. Here, I show the beginnings of what it would look like for us to adopt the MVVM pattern. I've created a CallViewModel and TileViewModel that expose their state to the UI as rxjs Observables, as well as a couple of helper functions for consuming view models in React code. This should contain no user-visible changes, but we need to watch out for regressions particularly around focus switching and promotion of speakers, because this was the logic I chose to refactor first. |
||
|---|---|---|
| .. | ||
| ArrowDown.svg | ||
| Audio.svg | ||
| AudioLow.svg | ||
| AudioMuted.svg | ||
| Check.svg | ||
| Chevron.svg | ||
| Close.svg | ||
| Copy.svg | ||
| Developer.svg | ||
| Edit.svg | ||
| Feedback.svg | ||
| Fullscreen.svg | ||
| FullscreenExit.svg | ||
| LockOff.svg | ||
| Login.svg | ||
| Logo.svg | ||
| LogoLarge.svg | ||
| LogoMark.svg | ||
| LogoType.svg | ||
| Logout.svg | ||
| Overflow.svg | ||
| Settings.svg | ||
| StarSelected.svg | ||
| StarUnselected.svg | ||
| User.svg | ||
| Video.svg | ||
