Commit Graph

84 Commits

Author SHA1 Message Date
Robin
c433069f90 Format code 2023-11-30 23:40:33 -05:00
renovate[bot]
8bb114d7d4
Update dependency @livekit/components-react to v1.4.1 (#1923)
* Update dependency @livekit/components-react to v1.4.1

* patch to match new lk api

Signed-off-by: Timo K <toger5@hotmail.de>

---------

Signed-off-by: Timo K <toger5@hotmail.de>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Timo K <toger5@hotmail.de>
2023-11-28 20:01:12 +01:00
David Baker
861d8ec016 Fix joining calls with no media permission
You can still try to unmute your media in the preview screen and
the button will show unmuted, but then mute again once you actually
join, so not 100% perfect but better.

Fixes https://github.com/vector-im/element-call/issues/1907
Fixes https://github.com/vector-im/element-call/issues/1661
2023-11-20 18:49:08 +00:00
David Baker
081c42f5bc
Merge pull request #1892 from vector-im/dbkr/focus_switch_keep_screenshare
Keep screenshares when switching focus
2023-11-16 09:39:17 +00:00
David Baker
57ca5d1713 Another comment 2023-11-15 16:23:06 +00:00
David Baker
56c4ad088f
Merge pull request #1891 from vector-im/dbkr/require_e2eeconfig
Make E2EEConfig required
2023-11-15 16:13:17 +00:00
David Baker
c146e83c15 Keep screenshares when switching focus
This also removes the use of the useLivekitRoom hook: we had reached
the point where the only thing it was actually doing was disconnecting,
so we now do that in the onClick handler for the leave button (I don't
think we need to disconnect on unmount?). It was otherwise just getting in
the way and causing tracks to be enabled/disabled when we didn't want them
to be. This also removes the need for the blockAudio code.

Fixes https://github.com/vector-im/element-call/issues/1413
2023-11-10 15:24:43 +00:00
David Baker
5ab6d18712 Make E2EEConfig required
Previously it could be either undefined or type None which meant the
same thing: no need to have both, just make it required.

This also means we can move the line to set e2ee enabled into a more
sensible place rather than in the ActiveCall de-nulling wrapper.
2023-11-10 11:54:59 +00:00
David Baker
e4e721818a Close precreated tracks if we never add them
As the log line says, this should never happen, but if it does we
still shouldn't leak tracks.
2023-11-10 11:18:20 +00:00
David Baker
731f1e4008
Merge pull request #1772 from vector-im/dbkr/ppe2ee
Support key-per-participant e2ee
2023-10-31 20:08:05 +00:00
David Baker
49c90a4612 Amalgamate E2EEMode & E2eeType 2023-10-30 17:06:59 +00:00
David Baker
bc0d679d50 Add sentry message if we hit the extra mic check
If we hit the condition detecting that we're trying to add an extra
mic input, send a sentry message so we know if this is happening in
the wild.
2023-10-27 16:18:00 +01:00
David Baker
2d5b4dbc57 Merge remote-tracking branch 'origin/livekit' into dbkr/ppe2ee 2023-10-26 10:29:12 +01:00
Timo
8356b722a6
Add limit condition to sync loop and add more logging what is actually going on. (#1775)
---------

Signed-off-by: Timo K <toger5@hotmail.de>
2023-10-25 13:44:33 +02:00
David Baker
15d3e7574d Re-apply Simon's emebdded e2ee work on latest livekit branch
Replaces https://github.com/vector-im/element-call/pull/1350
2023-10-16 17:45:06 +01:00
David Baker
2faf9527a0 Fix using a non-default audio device
We were passing the output option when we wanted the input, so the
mic track pre-creation would just always use the system default.
2023-10-13 13:34:25 +01:00
David Baker
61d7adf0d4
Merge pull request #1740 from vector-im/dbkr/log_mic_and_focus
Add logging & guards for mic pre-creation & focus
2023-10-13 10:34:41 +01:00
Timo
5262af7000
Fix sync loop by adding a 20ms break for the next mute sync (#1742)
* fix sync loop by adding a 20ms break for the next mute sync

---------

Signed-off-by: Timo K <toger5@hotmail.de>
2023-10-12 10:51:37 +02:00
David Baker
11664a5bf6 Prettier 2023-10-11 16:27:17 +01:00
David Baker
a9c74172a5 Add logging & guards for mic pre-creation & focus
Logs & guard for pre-recating the mic track as well as logging what
we select as the active focus (JWT URL + livekit alias).
2023-10-11 16:07:46 +01:00
Robin
614bc82402 Format code 2023-10-11 10:42:04 -04:00
Robin
cc6f1f8631 Merge branch 'livekit' into eslint-upgrade 2023-10-11 10:30:57 -04:00
Timo
d5edcce470
Fix mute button not being in sync with actual video/audio feed. (#1721)
* Fix mute button not being in sync with actual video/audio feed.
This happens if we toggle the button while waiting for updating the stream.
It is prohibited by checking if the stream state is in sync after the update
is done.
Signed-off-by: Timo K <toger5@hotmail.de>


---------

Signed-off-by: Timo K <toger5@hotmail.de>
2023-10-10 14:14:39 +02:00
David Baker
c37b2924af Comment 2023-10-03 18:27:10 +01:00
David Baker
e0cabbc514 Switch capture devices if the default device changes
This is a bit of a hack, but is the only way I can see that we can
update to using the new default device when the OS-level default
changes. Hopefully the comments explain everything.
2023-10-03 18:22:56 +01:00
David Baker
4613d43c3c Re-enable livekit rageshake logging & with depth limit
Puts livekit logs back in the rageshake logs and adds a recursion
limit to the object serialiser in rageshake.
2023-09-26 12:08:08 +01:00
David Baker
b0f63eb2ff
Revert "Capture livekit's logs in rageshakes" 2023-09-25 09:32:32 +01:00
Robin
a7624806b2 Upgrade eslint-plugin-matrix-org to 1.2.1
This upgrade came with a number of new lints that needed to be fixed across the code base. Primarily: explicit return types on functions, and explicit visibility modifiers on class members.
2023-09-22 18:07:06 -04:00
David Baker
9bf0dc7dee Unused import 2023-09-21 16:58:02 +01:00
David Baker
9c878eab80 Capture livekit's logs in rageshakes 2023-09-21 16:50:31 +01:00
Robin
69bf3bd9a1 Fix double audio tracks
See comments. I'm not very happy with how this code bounces state in and out of different hooks and useEffect blocks, but as a quick fix this should work.
2023-09-20 13:26:34 -04:00
Timo
9f832127b2
Fix comments (workaround gh weirdness) (#1518)
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 16:17:08 +02:00
Timo
4aec5c34f3
Firefox audio output issues fix (#1510)
---------

Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 15:10:14 +02:00
Robin
aaf4d20e7d Merge branch 'livekit' into use-modals 2023-09-18 11:40:10 -04:00
Timo
b979fc85bb
Check for existing track before creating one. (#1459)
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-18 12:43:03 +02:00
Robin
9db21e024e Start using the new modal component
This attempts to converge all our modals on the new modal component while changing their designs as little as possible. This should reduce the bundle size a bit and make the app generally feel like it's converging on the new designs, even though individual modals still remain to be revamped.
2023-09-17 14:46:36 -04:00
David Baker
2c1692bd4f Always publish microphone track when joining 2023-09-08 17:22:02 +01:00
David Baker
b256755a0d Don't treat empty object as a valid sfu config
This was causing an extra reconnect cycle when the call was first
joined because it thought the previous SFU config was valid. This was
probably causing some client to fail to connect at all.
2023-08-31 09:44:23 +01:00
David Baker
b5626dd97c Merge remote-tracking branch 'origin/livekit' into dbkr/matrixrtcsession 2023-08-30 17:25:00 +01:00
David Baker
3a0c895b7a Fix e2ee audio in Firefox
Pull in changes for livekit and disable RED as per comment.
2023-08-30 17:17:45 +01:00
David Baker
4cd274b91e Manually disconnect & reconnect the livekit call if our focus changes
Without breaking the 'disconnected' screen
2023-08-29 12:45:34 +01:00
David Baker
918736e758 Removed now unused useGroupCall & OpenIDLoader 2023-08-23 10:06:08 +01:00
David Baker
e39d00154d More hacking on rtcsession 2023-08-18 09:03:21 +01:00
Robin Townsend
e04d3f7c8d Fix camera light regression
By avoiding a method call that was accidentally causing LiveKit to try to publish tracks before the SFU connection was established, resulting in an unclosed stream.
2023-08-04 13:15:24 -04:00
Robin Townsend
99ce5064f5 Fix multiple issues with device settings
To track media devices, we were previously relying on a combination of LiveKit's useMediaDeviceSelect hook, and an object called UserChoices. Device settings should be accessible from outside a call, but the latter hook should only be used with a room or set of preview tracks, so it couldn't be raised to the app's top level. I also felt that the UserChoices code was hard to follow due to lack of clear ownership of the object.

To bring clarity to media device handling and allow device settings to be shown outside a call, I refactored these things into a single MediaDevicesContext which is instantiated at the top level of the app. Then, I had to manually sync LiveKit's device state with whatever is present in the context. This refactoring ended up fixing a couple other bugs with device handling along the way.
2023-08-03 10:17:00 -04:00
Šimon Brandner
f7645ab432
Merge remote-tracking branch 'upstream/livekit' into SimonBrandner/feat/e2ee
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-07-25 16:00:12 +02:00
Šimon Brandner
7c5f07b498
Add a comment
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-07-25 15:49:59 +02:00
Šimon Brandner
8ee0e207bd
Automatically mute the user, if there already are more than 8 participants
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-07-24 12:06:51 +02:00
David Baker
4eb9326bd2 Enable debug logging
Fixes https://github.com/vector-im/element-call/issues/1267
2023-07-17 19:33:29 +01:00
Šimon Brandner
4193629c2c
Add E2EE password prompt
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-07-17 16:53:58 +02:00