Merge pull request #809 from vector-im/dbkr/optional_rageshake

Don't show option to submit bug reports if no endpoint configured
This commit is contained in:
David Baker 2023-01-03 09:55:08 +00:00 committed by GitHub
commit dc37c83aac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 7 deletions

View File

@ -11,7 +11,8 @@
"<0>Already have an account?</0><1><0>Log in</0> Or <2>Access as a guest</2></1>": "<0>Already have an account?</0><1><0>Log in</0> Or <2>Access as a guest</2></1>", "<0>Already have an account?</0><1><0>Log in</0> Or <2>Access as a guest</2></1>": "<0>Already have an account?</0><1><0>Log in</0> Or <2>Access as a guest</2></1>",
"<0>Create an account</0> Or <2>Access as a guest</2>": "<0>Create an account</0> Or <2>Access as a guest</2>", "<0>Create an account</0> Or <2>Access as a guest</2>": "<0>Create an account</0> Or <2>Access as a guest</2>",
"<0>Join call now</0><1>Or</1><2>Copy call link and join later</2>": "<0>Join call now</0><1>Or</1><2>Copy call link and join later</2>", "<0>Join call now</0><1>Or</1><2>Copy call link and join later</2>": "<0>Join call now</0><1>Or</1><2>Copy call link and join later</2>",
"<0>Oops, something's gone wrong.</0><1>Submitting debug logs will help us track down the problem.</1>": "<0>Oops, something's gone wrong.</0><1>Submitting debug logs will help us track down the problem.</1>", "<0>Oops, something's gone wrong.</0>": "<0>Oops, something's gone wrong.</0>",
"<0>Submitting debug logs will help us track down the problem.</0>": "<0>Submitting debug logs will help us track down the problem.</0>",
"<0>Why not finish by setting up a password to keep your account?</0><1>You'll be able to keep your name and set an avatar for use on future calls</1>": "<0>Why not finish by setting up a password to keep your account?</0><1>You'll be able to keep your name and set an avatar for use on future calls</1>", "<0>Why not finish by setting up a password to keep your account?</0><1>You'll be able to keep your name and set an avatar for use on future calls</1>": "<0>Why not finish by setting up a password to keep your account?</0><1>You'll be able to keep your name and set an avatar for use on future calls</1>",
"Accept camera/microphone permissions to join the call.": "Accept camera/microphone permissions to join the call.", "Accept camera/microphone permissions to join the call.": "Accept camera/microphone permissions to join the call.",
"Accept microphone permissions to join the call.": "Accept microphone permissions to join the call.", "Accept microphone permissions to join the call.": "Accept microphone permissions to join the call.",

View File

@ -9,6 +9,7 @@ import { useSubmitRageshake } from "./settings/submit-rageshake";
import { ErrorMessage } from "./input/Input"; import { ErrorMessage } from "./input/Input";
import styles from "./FullScreenView.module.css"; import styles from "./FullScreenView.module.css";
import { translatedError, TranslatedError } from "./TranslatedError"; import { translatedError, TranslatedError } from "./TranslatedError";
import { Config } from "./config/Config";
interface FullScreenViewProps { interface FullScreenViewProps {
className?: string; className?: string;
@ -98,7 +99,7 @@ export function CrashView() {
logsComponent = <div>{t("Thanks! We'll get right on it.")}</div>; logsComponent = <div>{t("Thanks! We'll get right on it.")}</div>;
} else if (sending) { } else if (sending) {
logsComponent = <div>{t("Sending…")}</div>; logsComponent = <div>{t("Sending…")}</div>;
} else { } else if (Config.get().rageshake?.submit_url) {
logsComponent = ( logsComponent = (
<Button <Button
size="lg" size="lg"
@ -115,8 +116,13 @@ export function CrashView() {
<FullScreenView> <FullScreenView>
<Trans> <Trans>
<h1>Oops, something's gone wrong.</h1> <h1>Oops, something's gone wrong.</h1>
</Trans>
{Config.get().rageshake?.submit_url && (
<Trans>
<p>Submitting debug logs will help us track down the problem.</p> <p>Submitting debug logs will help us track down the problem.</p>
</Trans> </Trans>
)}
<div className={styles.sendLogsSection}>{logsComponent}</div> <div className={styles.sendLogsSection}>{logsComponent}</div>
{error && ( {error && (
<ErrorMessage error={translatedError("Couldn't send debug logs!", t)} /> <ErrorMessage error={translatedError("Couldn't send debug logs!", t)} />

View File

@ -32,6 +32,7 @@ import { SettingsModal } from "../settings/SettingsModal";
import { InviteModal } from "./InviteModal"; import { InviteModal } from "./InviteModal";
import { TooltipTrigger } from "../Tooltip"; import { TooltipTrigger } from "../Tooltip";
import { FeedbackModal } from "./FeedbackModal"; import { FeedbackModal } from "./FeedbackModal";
import { Config } from "../config/Config";
interface Props { interface Props {
roomIdOrAlias: string; roomIdOrAlias: string;
@ -117,10 +118,12 @@ export function OverflowMenu({
<SettingsIcon /> <SettingsIcon />
<span>{t("Settings")}</span> <span>{t("Settings")}</span>
</Item> </Item>
{Config.get().rageshake?.submit_url && (
<Item key="feedback" textValue={t("Submit feedback")}> <Item key="feedback" textValue={t("Submit feedback")}>
<FeedbackIcon /> <FeedbackIcon />
<span>{t("Submit feedback")}</span> <span>{t("Submit feedback")}</span>
</Item> </Item>
)}
</Menu> </Menu>
)} )}
</PopoverMenuTrigger> </PopoverMenuTrigger>