mirror of
https://github.com/vector-im/element-call.git
synced 2024-11-24 00:38:31 +08:00
Refactor if expression
Split the check on a boolean into another branch
This commit is contained in:
parent
6486ffe777
commit
538332df66
@ -178,29 +178,31 @@ export const GroupCallView: FC<Props> = ({
|
|||||||
};
|
};
|
||||||
|
|
||||||
if (skipLobby) {
|
if (skipLobby) {
|
||||||
if (widget && preload) {
|
if (widget) {
|
||||||
// In preload mode without lobby we wait for a join action before entering
|
if (preload) {
|
||||||
const onJoin = (ev: CustomEvent<IWidgetApiRequest>): void => {
|
// In preload mode without lobby we wait for a join action before entering
|
||||||
|
const onJoin = (ev: CustomEvent<IWidgetApiRequest>): void => {
|
||||||
|
(async (): Promise<void> => {
|
||||||
|
await defaultDeviceSetup(ev.detail.data as unknown as JoinCallData);
|
||||||
|
await enterRTCSession(rtcSession, perParticipantE2EE);
|
||||||
|
widget!.api.transport.reply(ev.detail, {});
|
||||||
|
})().catch((e) => {
|
||||||
|
logger.error("Error joining RTC session", e);
|
||||||
|
});
|
||||||
|
};
|
||||||
|
widget.lazyActions.on(ElementWidgetActions.JoinCall, onJoin);
|
||||||
|
return (): void => {
|
||||||
|
widget!.lazyActions.off(ElementWidgetActions.JoinCall, onJoin);
|
||||||
|
};
|
||||||
|
} else {
|
||||||
|
// No lobby and no preload: we enter the rtc session right away
|
||||||
(async (): Promise<void> => {
|
(async (): Promise<void> => {
|
||||||
await defaultDeviceSetup(ev.detail.data as unknown as JoinCallData);
|
await defaultDeviceSetup({ audioInput: null, videoInput: null });
|
||||||
await enterRTCSession(rtcSession, perParticipantE2EE);
|
await enterRTCSession(rtcSession, perParticipantE2EE);
|
||||||
widget!.api.transport.reply(ev.detail, {});
|
|
||||||
})().catch((e) => {
|
})().catch((e) => {
|
||||||
logger.error("Error joining RTC session", e);
|
logger.error("Error joining RTC session", e);
|
||||||
});
|
});
|
||||||
};
|
}
|
||||||
widget.lazyActions.on(ElementWidgetActions.JoinCall, onJoin);
|
|
||||||
return (): void => {
|
|
||||||
widget!.lazyActions.off(ElementWidgetActions.JoinCall, onJoin);
|
|
||||||
};
|
|
||||||
} else if (widget && !preload) {
|
|
||||||
// No lobby and no preload: we enter the rtc session right away
|
|
||||||
(async (): Promise<void> => {
|
|
||||||
await defaultDeviceSetup({ audioInput: null, videoInput: null });
|
|
||||||
await enterRTCSession(rtcSession, perParticipantE2EE);
|
|
||||||
})().catch((e) => {
|
|
||||||
logger.error("Error joining RTC session", e);
|
|
||||||
});
|
|
||||||
} else {
|
} else {
|
||||||
void enterRTCSession(rtcSession, perParticipantE2EE);
|
void enterRTCSession(rtcSession, perParticipantE2EE);
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user