Matrix/element-call-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-call.git synced 2024-11-15 00:04:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Address some review feedback

Browse Source
This commit is contained in:
Robin 2024-07-12 14:01:32 -04:00
parent 20602c122b
commit 14fc1481f3
9 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Header.module.css
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2022 New Vector Ltd Copyright 2022-2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.

2
src/Header.tsx
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2022 New Vector Ltd Copyright 2022-2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.

2
src/grid/LegacyGrid.module.css
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2022 New Vector Ltd Copyright 2022-2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.

2
src/grid/LegacyGrid.tsx
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2022-2023 New Vector Ltd Copyright 2022-2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.

2
src/grid/TileWrapper.tsx
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2023 New Vector Ltd Copyright 2023-2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.

4
src/room/InCallView.tsx
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2022 - 2023 New Vector Ltd Copyright 2022 - 2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.
@ -266,7 +266,7 @@ export const InCallView: FC<InCallViewProps> = subscribe(
// useFullscreen so that we can control the fullscreen state of the // useFullscreen so that we can control the fullscreen state of the
// spotlight tile in the new layouts with this same hook. // spotlight tile in the new layouts with this same hook.
const fullscreenItems = useMemo( const fullscreenItems = useMemo(
() => [...items, ...(hasSpotlight ? [dummySpotlightItem] : [])], () => (hasSpotlight ? [...items, dummySpotlightItem] : items),
[items, hasSpotlight], [items, hasSpotlight],
); );
const { fullscreenItem, toggleFullscreen, exitFullscreen } = const { fullscreenItem, toggleFullscreen, exitFullscreen } =

2
src/room/VideoPreview.tsx
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2022 - 2023 New Vector Ltd Copyright 2022 - 2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.

3
src/useReactiveState.ts
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2023 New Vector Ltd Copyright 2023-2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.
@ -44,6 +44,7 @@ export const useReactiveState = <T>(
if ( if (
prevDeps.current === undefined || prevDeps.current === undefined ||
deps.length !== prevDeps.current.length || deps.length !== prevDeps.current.length ||
// Deps might be NaN, so we compare with Object.is rather than ===
deps.some((d, i) => !Object.is(d, prevDeps.current![i])) deps.some((d, i) => !Object.is(d, prevDeps.current![i]))
) { ) {
state.current = updateFn(state.current); state.current = updateFn(state.current);

2
test/grid/LegacyGrid-test.ts
View File

@ -1,5 +1,5 @@
/* /*
Copyright 2023 New Vector Ltd Copyright 2023-2024 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.