mirror of
https://github.com/vector-im/element-android.git
synced 2024-11-25 15:08:12 +08:00
17 lines
1.3 KiB
Markdown
17 lines
1.3 KiB
Markdown
### Pull Request Checklist
|
|
|
|
<!--
|
|
Please read [CONTRIBUTING.md](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md) before submitting your pull request
|
|
Depending on the Pull Request content, it can be acceptable if some of the following checkboxes stay unchecked.
|
|
-->
|
|
|
|
- [ ] Changes has been tested on an Android device or Android emulator with API 21
|
|
- [ ] UI change has been tested on both light and dark themes
|
|
- [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
|
|
- [ ] Pull request is based on the develop branch
|
|
- [ ] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
|
|
- [ ] Pull request includes screenshots or videos if containing UI changes
|
|
- [ ] Pull request includes a [sign off](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off)
|
|
- [ ] You've made a self review of your PR
|
|
- [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test [UiAllScreensSanityTest.allScreensTest()](https://github.com/vector-im/element-android/blob/main/vector/src/androidTest/java/im/vector/app/ui/UiAllScreensSanityTest.kt#L73)
|