Fix issue on setting avatar on a room.

We deleted the just added avatar because `withState {}` is asynchronous

CHANGES.md

@@ -8,7 +8,7 @@ Improvements 🙌:
  -
 
 Bugfix 🐛:
- -
+ - Fix issue when updating the avatar of a room
 
 Translations 🗣:
  -

vector/src/main/java/im/vector/app/features/roomprofile/settings/RoomSettingsViewModel.kt

@@ -153,20 +153,20 @@ class RoomSettingsViewModel @AssistedInject constructor(@Assisted initialState:
     }
 
     private fun handleSetAvatarAction(action: RoomSettingsAction.SetAvatarAction) {
-        deletePendingAvatar()
-        setState { copy(avatarAction = action.avatarAction) }
+        setState {
+            deletePendingAvatar(this)
+            copy(avatarAction = action.avatarAction)
+        }
     }
 
-    private fun deletePendingAvatar() {
+    private fun deletePendingAvatar(state: RoomSettingsViewState) {
         // Maybe delete the pending avatar
-        withState {
-            (it.avatarAction as? RoomSettingsViewState.AvatarAction.UpdateAvatar)
+        (state.avatarAction as? RoomSettingsViewState.AvatarAction.UpdateAvatar)
                 ?.let { tryOrNull { it.newAvatarUri.toFile().delete() } }
     }
-    }
 
     private fun cancel() {
-        deletePendingAvatar()
+        withState { deletePendingAvatar(it) }
 
         _viewEvents.post(RoomSettingsViewEvents.GoBack)
     }
@@ -209,8 +209,10 @@ class RoomSettingsViewModel @AssistedInject constructor(@Assisted initialState:
                 .subscribe(
                         {
                             postLoading(false)
-                            setState { copy(newHistoryVisibility = null) }
-                            deletePendingAvatar()
+                            setState {
+                                deletePendingAvatar(this)
+                                copy(newHistoryVisibility = null)
+                            }
                             _viewEvents.post(RoomSettingsViewEvents.Success)
                         },
                         {