From a6113526d037e1494436cf0cdc6420101606eb8d Mon Sep 17 00:00:00 2001 From: Valere Date: Tue, 7 Jun 2022 09:39:32 +0200 Subject: [PATCH] code review --- changelog.d/6233.bugfix | 1 + .../matrix/android/sdk/api/session/room/RoomService.kt | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 changelog.d/6233.bugfix diff --git a/changelog.d/6233.bugfix b/changelog.d/6233.bugfix new file mode 100644 index 0000000000..0c415e1078 --- /dev/null +++ b/changelog.d/6233.bugfix @@ -0,0 +1 @@ +Fix | performance regression on roomlist + proper display of space parents in explore rooms. diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/RoomService.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/RoomService.kt index 5d3b1f4c4a..1e022ef02a 100644 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/RoomService.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/RoomService.kt @@ -216,8 +216,12 @@ interface RoomService { sortOrder: RoomSortOrder = RoomSortOrder.ACTIVITY): LiveData> /** - * TODO Doc. - * @param getFlattenParents When true, the list of known parent and grand parent summaries will be resolved. + * Get's a live paged list from a filter that can be dynamically updated. + * + * @param queryParams The filter to use + * @param pagedListConfig The paged list configuration (page size, initial load, prefetch distance...) + * @param sortOrder defines how to sort the results + * @param getFlattenParents When true, the list of known parents and grand parents summaries will be resolved. * This can have significant impact on performance, better be used only on manageable list (filtered by displayName, ..). */ fun getFilteredPagedRoomSummariesLive(