code review

This commit is contained in:
Valere 2022-06-07 09:39:32 +02:00 committed by Benoit Marty
parent 2fa25f8b5e
commit a6113526d0
2 changed files with 7 additions and 2 deletions

1
changelog.d/6233.bugfix Normal file
View File

@ -0,0 +1 @@
Fix | performance regression on roomlist + proper display of space parents in explore rooms.

View File

@ -216,8 +216,12 @@ interface RoomService {
sortOrder: RoomSortOrder = RoomSortOrder.ACTIVITY): LiveData<PagedList<RoomSummary>>
/**
* TODO Doc.
* @param getFlattenParents When true, the list of known parent and grand parent summaries will be resolved.
* Get's a live paged list from a filter that can be dynamically updated.
*
* @param queryParams The filter to use
* @param pagedListConfig The paged list configuration (page size, initial load, prefetch distance...)
* @param sortOrder defines how to sort the results
* @param getFlattenParents When true, the list of known parents and grand parents summaries will be resolved.
* This can have significant impact on performance, better be used only on manageable list (filtered by displayName, ..).
*/
fun getFilteredPagedRoomSummariesLive(