Matrix/element-android-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-android.git synced 2024-11-16 02:05:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

There is no need to call job.cancel() when we are using viewModelScope()

Browse Source
This commit is contained in:
ariskotsomitopoulos 2021-12-01 13:15:03 +00:00
parent 2e52f429fb
commit 9f1e327fa5
3 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/4602.misc Normal file
View File

@ -0,0 +1 @@
There is no need to call job.cancel() when we are using viewModelScope()

1
vector/src/main/java/im/vector/app/features/home/room/detail/search/SearchViewModel.kt
View File

@ -143,7 +143,6 @@ class SearchViewModel @AssistedInject constructor(
}
override fun onCleared() {
currentTask?.cancel()
super.onCleared()
}
}

1
vector/src/main/java/im/vector/app/features/roomdirectory/RoomDirectoryViewModel.kt
View File

@ -233,7 +233,6 @@ class RoomDirectoryViewModel @AssistedInject constructor(
}
override fun onCleared() {
currentJob?.cancel()
super.onCleared()
}
}