More renaming

This commit is contained in:
Benoit Marty 2021-01-12 16:18:29 +01:00
parent b2df107f17
commit 50ba131350
2 changed files with 20 additions and 8 deletions

View File

@ -120,7 +120,11 @@ abstract class SyncService : Service() {
serviceScope.coroutineContext.cancelChildren()
if (!preventReschedule && periodic && sessionId != null && backgroundDetectionObserver.isInBackground) {
Timber.d("## Sync: Reschedule service in $syncDelaySeconds sec")
onRescheduleAsked(sessionId ?: "", syncTimeoutSeconds, syncDelaySeconds)
onRescheduleAsked(
sessionId = sessionId ?: "",
syncTimeoutSeconds = syncTimeoutSeconds,
syncDelaySeconds = syncDelaySeconds
)
}
super.onDestroy()
}
@ -177,7 +181,11 @@ abstract class SyncService : Service() {
// Network might be off, no need to reschedule endless alarms :/
preventReschedule = true
// Instead start a work to restart background sync when network is on
onNetworkError(sessionId ?: "", syncTimeoutSeconds, syncDelaySeconds)
onNetworkError(
sessionId = sessionId ?: "",
syncTimeoutSeconds = syncTimeoutSeconds,
syncDelaySeconds = syncDelaySeconds
)
}
// JobCancellation could be caught here when onDestroy cancels the coroutine context
if (isRunning.get()) stopMe()
@ -217,9 +225,9 @@ abstract class SyncService : Service() {
abstract fun onStart(isInitialSync: Boolean)
abstract fun onRescheduleAsked(sessionId: String, timeout: Int, delay: Int)
abstract fun onRescheduleAsked(sessionId: String, syncTimeoutSeconds: Int, syncDelaySeconds: Int)
abstract fun onNetworkError(sessionId: String, timeout: Int, delay: Int)
abstract fun onNetworkError(sessionId: String, syncTimeoutSeconds: Int, syncDelaySeconds: Int)
override fun onBind(intent: Intent?): IBinder? {
return null

View File

@ -92,15 +92,19 @@ class VectorSyncService : SyncService() {
startForeground(NotificationUtils.NOTIFICATION_ID_FOREGROUND_SERVICE, notification)
}
override fun onRescheduleAsked(sessionId: String, timeout: Int, delay: Int) {
rescheduleSyncService(sessionId, timeout, delay, false)
override fun onRescheduleAsked(sessionId: String,
syncTimeoutSeconds: Int,
syncDelaySeconds: Int) {
rescheduleSyncService(sessionId, syncTimeoutSeconds, syncDelaySeconds, false)
}
override fun onNetworkError(sessionId: String, timeout: Int, delay: Int) {
override fun onNetworkError(sessionId: String,
syncTimeoutSeconds: Int,
syncDelaySeconds: Int) {
Timber.d("## Sync: A network error occurred during sync")
val rescheduleSyncWorkRequest: WorkRequest =
OneTimeWorkRequestBuilder<RestartWhenNetworkOn>()
.setInputData(RestartWhenNetworkOn.createInputData(sessionId, timeout, delay))
.setInputData(RestartWhenNetworkOn.createInputData(sessionId, syncTimeoutSeconds, syncDelaySeconds))
.setConstraints(Constraints.Builder()
.setRequiredNetworkType(NetworkType.CONNECTED)
.build()