From 4c238e81cf6cf08bdf99c98ffabe7f26ffab1472 Mon Sep 17 00:00:00 2001 From: Adam Brown Date: Wed, 15 Dec 2021 18:16:10 +0000 Subject: [PATCH 1/2] dismisses any potential loading dialogs when the linked fragment is destroyed - fixes leaking the activity window when the fragment is destroyed --- .../main/java/im/vector/app/core/platform/VectorBaseFragment.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt b/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt index eab1101064..64443139f1 100644 --- a/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt +++ b/vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt @@ -151,6 +151,7 @@ abstract class VectorBaseFragment : Fragment(), MavericksView override fun onDestroyView() { Timber.i("onDestroyView Fragment ${javaClass.simpleName}") _binding = null + dismissLoadingDialog() super.onDestroyView() } From eb9c46b9a265370102e636b204be9eff3115871e Mon Sep 17 00:00:00 2001 From: Adam Brown Date: Wed, 15 Dec 2021 18:17:04 +0000 Subject: [PATCH 2/2] adding changelog entry --- changelog.d/4713.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/4713.misc diff --git a/changelog.d/4713.misc b/changelog.d/4713.misc new file mode 100644 index 0000000000..5207c03871 --- /dev/null +++ b/changelog.d/4713.misc @@ -0,0 +1 @@ +Avoids leaking the activity windows when loading dialogs are displaying \ No newline at end of file