Matrix/element-android-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-android.git synced 2024-11-16 02:05:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

inlining posthog creation and removing eager optout and identify calls as the backing values are null which means they aren't actually being called

Browse Source
This commit is contained in:
Adam Brown 2022-02-15 15:39:05 +00:00
parent e36e67c54c
commit 3236d87323
1 changed files with 15 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
vector/src/main/java/im/vector/app/features/analytics/impl/DefaultVectorAnalytics.kt
View File

@ -40,17 +40,29 @@ private val IGNORED_OPTIONS: Options? = null
@Singleton
class DefaultVectorAnalytics @Inject constructor(
private val postHogFactory: PostHogFactory,
postHogFactory: PostHogFactory,
analyticsConfig: AnalyticsConfig,
private val analyticsStore: AnalyticsStore,
private val analyticsConfig: AnalyticsConfig,
@NamedGlobalScope private val globalScope: CoroutineScope
) : VectorAnalytics {
private var posthog: PostHog? = null
private val posthog: PostHog? = when {
analyticsConfig.isEnabled -> postHogFactory.createPosthog()
else -> {
Timber.tag(analyticsTag.value).w("Analytics is disabled")
null
}
}
// Cache for the store values
private var userConsent: Boolean? = null
private var analyticsId: String? = null
override fun init() {
observeUserConsent()
observeAnalyticsId()
}
override fun getUserConsent(): Flow<Boolean> {
return analyticsStore.userConsentFlow
}
@ -83,12 +95,6 @@ class DefaultVectorAnalytics @Inject constructor(
setAnalyticsId("")
}
override fun init() {
createAnalyticsClient()
observeUserConsent()
observeAnalyticsId()
}
private fun observeAnalyticsId() {
getAnalyticsId()
.onEach { id ->
@ -113,7 +119,6 @@ class DefaultVectorAnalytics @Inject constructor(
private fun observeUserConsent() {
getUserConsent()
.onEach { consent ->
println("!!!, got consent: $consent")
Timber.tag(analyticsTag.value).d("User consent updated to $consent")
userConsent = consent
optOutPostHog()
@ -125,20 +130,6 @@ class DefaultVectorAnalytics @Inject constructor(
userConsent?.let { posthog?.optOut(!it) }
}
private fun createAnalyticsClient() {
Timber.tag(analyticsTag.value).d("createAnalyticsClient()")
if (analyticsConfig.isEnabled.not()) {
Timber.tag(analyticsTag.value).w("Analytics is disabled")
return
}
posthog = postHogFactory.createPosthog()
optOutPostHog()
identifyPostHog()
}
override fun capture(event: VectorAnalyticsEvent) {
Timber.tag(analyticsTag.value).d("capture($event)")
posthog
@ -148,9 +139,6 @@ class DefaultVectorAnalytics @Inject constructor(
override fun screen(screen: VectorAnalyticsScreen) {
Timber.tag(analyticsTag.value).d("screen($screen)")
println("userconsnet: $userConsent")
posthog
?.takeIf { userConsent == true }
?.screen(screen.getName(), screen.getProperties()?.toPostHogProperties())