Matrix/element-android-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-android.git synced 2024-11-15 01:35:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make it easier to find developer sign-off instructions (#6739)

Browse Source 
* Make it easier to find sign-off instructions by linking directly to DCO docs from danger message.
This commit is contained in:
Michael Kaye 2022-08-04 15:54:53 +01:00 committed by GitHub
parent e26d87c73d
commit 09a91c4541
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/6739.misc Normal file
View File

@ -0,0 +1 @@
Link directly to DCO docs from danger message.

2
tools/danger/dangerfile.js
View File

@ -83,7 +83,7 @@ if (requiresSignOff) {
const hasPRBodySignOff = pr.body.includes(signOff)
const hasCommitSignOff = danger.git.commits.every(commit => commit.message.includes(signOff))
if (!hasPRBodySignOff && !hasCommitSignOff) {
fail("Please add a sign-off to either the PR description or to the commits themselves.")
fail("Please add a sign-off to either the PR description or to the commits themselves. See instructions [here](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off).")
}
}