FGFS-4.1/simgear
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Memory Leak: fix low-hanging fruit

Browse Source
This commit is contained in:
Scott Giese 2020-08-08 00:23:39 -05:00
parent abb1cd02cd
commit f76c640b69
2 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
simgear/io/http_repo_sync.cxx
View File

@ -2,6 +2,7 @@
#include <cstdio>
#include <cstring>
#include <memory>
#include <signal.h>
#include <iostream>
@ -63,7 +64,7 @@ int main(int argc, char* argv[])
}
SGPath rootPath = simgear::Dir::current().path();
HTTPRepository* repo = new HTTPRepository(rootPath, &cl);
auto repo = std::make_unique<HTTPRepository>(rootPath, &cl);
repo->setBaseUrl(url);
repo->update();

29
simgear/io/test_HTTP.cxx
View File

@ -2,6 +2,7 @@
#include <cstring>
#include <iostream>
#include <map>
#include <memory>
#include <sstream>
#include <cerrno>
@ -408,19 +409,23 @@ int main(int argc, char* argv[])
cl.setMaxConnections(1);
// test URL parsing
TestRequest* tr1 = new TestRequest("http://localhost.woo.zar:2000/test1?foo=bar");
SG_CHECK_EQUAL(tr1->scheme(), "http");
SG_CHECK_EQUAL(tr1->hostAndPort(), "localhost.woo.zar:2000");
SG_CHECK_EQUAL(tr1->host(), "localhost.woo.zar");
SG_CHECK_EQUAL(tr1->port(), 2000);
SG_CHECK_EQUAL(tr1->path(), "/test1");
{
auto tr1 = std::make_unique<TestRequest>("http://localhost.woo.zar:2000/test1?foo=bar");
SG_CHECK_EQUAL(tr1->scheme(), "http");
SG_CHECK_EQUAL(tr1->hostAndPort(), "localhost.woo.zar:2000");
SG_CHECK_EQUAL(tr1->host(), "localhost.woo.zar");
SG_CHECK_EQUAL(tr1->port(), 2000);
SG_CHECK_EQUAL(tr1->path(), "/test1");
}
TestRequest* tr2 = new TestRequest("http://192.168.1.1/test1/dir/thing/file.png");
SG_CHECK_EQUAL(tr2->scheme(), "http");
SG_CHECK_EQUAL(tr2->hostAndPort(), "192.168.1.1");
SG_CHECK_EQUAL(tr2->host(), "192.168.1.1");
SG_CHECK_EQUAL(tr2->port(), 80);
SG_CHECK_EQUAL(tr2->path(), "/test1/dir/thing/file.png");
{
auto tr2 = std::make_unique<TestRequest>("http://192.168.1.1/test1/dir/thing/file.png");
SG_CHECK_EQUAL(tr2->scheme(), "http");
SG_CHECK_EQUAL(tr2->hostAndPort(), "192.168.1.1");
SG_CHECK_EQUAL(tr2->host(), "192.168.1.1");
SG_CHECK_EQUAL(tr2->port(), 80);
SG_CHECK_EQUAL(tr2->path(), "/test1/dir/thing/file.png");
}
// basic get request
{