REVIEW: Memory Leak - Effect::buildAttribute()

144,400 bytes in 38 blocks are indirectly lost
2020-08-22 16:08:58 -05:00 · 2020-08-22 16:08:58 -05:00 · e3ce59ee80
commit e3ce59ee80
parent ce019a169b
1 changed files with 3 additions and 0 deletions
--- a/simgear/scene/material/Effect.cxx
+++ b/simgear/scene/material/Effect.cxx
@ -1101,6 +1101,9 @@ struct UniformBuilder :public PassAttributeBuilder
                uniform = colorMode[val];
            }
        }
+
+        // REVIEW: Memory Leak - 144,400 bytes in 38 blocks are indirectly lost
+        // Leak occurs within OSG, likely caused by passing a raw pointer
        pass->addUniform(uniform.get());
        if (positionedProp && positionedProp->getBoolValue() && uniformType == Uniform::FLOAT_VEC4) {
            osg::Vec4 offset;