From ce019a169b238b69673e66fec4fa1c9565bc56cf Mon Sep 17 00:00:00 2001
From: Scott Giese <scttgs0@gmail.com>
Date: Sat, 22 Aug 2020 15:53:25 -0500
Subject: [PATCH] REVIEW: Memory Leak - EffectBuilder::InitFromParameters()

156,910 (2,320 direct, 154,590 indirect) bytes in 29 blocks are definitely lost
---
 simgear/scene/material/EffectBuilder.hxx | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/simgear/scene/material/EffectBuilder.hxx b/simgear/scene/material/EffectBuilder.hxx
index 88703569..d1bb9031 100644
--- a/simgear/scene/material/EffectBuilder.hxx
+++ b/simgear/scene/material/EffectBuilder.hxx
@@ -618,6 +618,9 @@ initFromParameters(Effect* effect, const SGPropertyNode* prop, ObjType* obj,
     } else {
         setDynamicVariance(obj);
         std::string propName = getGlobalProperty(valProp, options);
+        // REVIEW: Memory Leak - 156,910 (2,320 direct, 154,590 indirect) bytes in 29 blocks are definitely lost
+        // Weak Efforts::dtor
+        // Weak UniformFactoryImpl handling of dynamic memory
         ScalarChangeListener<OSGParamType, ObjType, F>* listener
             = new ScalarChangeListener<OSGParamType, ObjType, F>(obj, setter,
                                                                  propName);