FGFS-4.1/simgear
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Memory Leak Fix - HTTPRepository

Browse Source 
Reclaimed 1,797,012 bytes in 7599 blocks
This commit is contained in:
Scott Giese 2020-08-23 22:15:28 -05:00
parent b8e06453ea
commit 423a0f65b0
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
simgear/io/HTTPRepository.cxx
View File

@ -581,9 +581,6 @@ private:
if (typeData == "d") ci.type = ChildInfo::DirectoryType; if (typeData == "d") ci.type = ChildInfo::DirectoryType;
if (typeData == "t") ci.type = ChildInfo::TarballType; if (typeData == "t") ci.type = ChildInfo::TarballType;
// REVIEW: Memory Leak - 447,264 bytes in 39 blocks are indirectly lost
// emplace_back is triggering an allocation which is leading to a leak
// Implies that ci is lacking a proper copy-ctor/assignment-op
children.emplace_back(ci); children.emplace_back(ci);
children.back().path = absolutePath() / tokens[1]; children.back().path = absolutePath() / tokens[1];
if (tokens.size() > 3) { if (tokens.size() > 3) {