Mac changes for Subversion bundling.

CMakeLists.txt

@@ -118,9 +118,6 @@ endif (MSVC AND MSVC_3RDPARTY_ROOT)
 find_package(Boost REQUIRED)
 set (BOOST_CXX_FLAGS "-DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DBOOST_BIMAP_DISABLE_SERIALIZATION")
 
-find_package(ZLIB REQUIRED)
-find_package(Threads REQUIRED)
-
 if(SIMGEAR_HEADLESS)
     message(STATUS "SimGear mode: HEADLESS")
 else()
@@ -156,6 +153,9 @@ else()
     message(STATUS "Subversion client support: DISABLED")
 endif(ENABLE_LIBSVN)
 
+find_package(ZLIB REQUIRED)
+find_package(Threads REQUIRED)
+
 check_include_file(sys/time.h HAVE_SYS_TIME_H)
 check_include_file(sys/timeb.h HAVE_SYS_TIMEB_H)
 check_include_file(unistd.h HAVE_UNISTD_H)

CMakeModules/FindSvnClient.cmake

@@ -16,14 +16,18 @@ macro(find_static_component comp libs)
     string(TOUPPER "${comp}" compLibBase)
     set( compLibName ${compLibBase}_LIBRARY )
 
+    # NO_DEFAULT_PATH is important on Mac - we need to ensure subversion
+    # libraires in dist/ or Macports are picked over the Apple version 
+    # in /usr, since that's what we will ship.
     FIND_LIBRARY(${compLibName}
+      NO_DEFAULT_PATH
       NAMES ${compLib}
-      HINTS $ENV{PLIBDIR}
+      HINTS $ENV{LIBSVN_DIR} ${CMAKE_INSTALL_PREFIX} 
       PATH_SUFFIXES lib64 lib libs64 libs libs/Win32 libs/Win64
       PATHS
+      /opt/local
       /usr/local
       /usr
-      /opt
     )
 
 	list(APPEND ${libs} ${${compLibName}})
@@ -49,13 +53,14 @@ endif(HAVE_APR_CONFIG)
 
 if(HAVE_APR_CONFIG OR MSVC)
 	find_path(LIBSVN_INCLUDE_DIR svn_client.h
+      NO_DEFAULT_PATH
 	  HINTS
-	  $ENV{LIBSVN_DIR}
+	  $ENV{LIBSVN_DIR} ${CMAKE_INSTALL_PREFIX}
 	  PATH_SUFFIXES include/subversion-1
 	  PATHS
+      /opt/local
 	  /usr/local
 	  /usr
-	  /opt
 	)
 	
 	set(LIBSVN_LIBRARIES "")

simgear/CMakeLists.txt

@@ -59,12 +59,7 @@ if(SIMGEAR_SHARED)
 
     if(LIBSVN_FOUND)
         add_definitions(${APR_CFLAGS})
-
-        IF(APPLE)
-            set_property(SOURCE scene/tsync/terrasync.cxx PROPERTY COMPILE_FLAGS "-iwithsysroot ${LIBSVN_INCLUDE_DIR}")
-        ELSE()
-            include_directories(${LIBSVN_INCLUDE_DIR})
-        ENDIF(APPLE)
+        include_directories(${LIBSVN_INCLUDE_DIR})
         target_link_libraries(SimGearCore ${LIBSVN_LIBRARIES})
     endif(LIBSVN_FOUND)
 

simgear/scene/tsync/CMakeLists.txt

@@ -10,13 +10,7 @@ set(SOURCES
 
 if(LIBSVN_FOUND)
 	add_definitions(${APR_CFLAGS})
-
-	IF(APPLE)
-		set_property(SOURCE terrasync.cxx PROPERTY COMPILE_FLAGS "-iwithsysroot ${LIBSVN_INCLUDE_DIR}")
-	ELSE()
-		include_directories(${LIBSVN_INCLUDE_DIR})
-	ENDIF(APPLE)
-
+	include_directories(${LIBSVN_INCLUDE_DIR})
 endif()
 
 simgear_component(tsync scene/tsync "${SOURCES}" "${HEADERS}")