FGFS-4.1/simgear
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Follow rule of three for HTTPRepo:ChildInfo

Browse Source
This commit is contained in:
James Turner 2020-08-22 21:30:53 +01:00
parent 8b14e56f88
commit 2c4120974c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
simgear/io/HTTPRepository.cxx
View File

@ -190,9 +190,8 @@ class HTTPDirectory
{ {
} }
// REVIEW: Memory Leak - 93,275 bytes in 2,275 blocks are indirectly lost
// Default copy-ctor is inappropriate when using dynamic memory allocation
ChildInfo(const ChildInfo& other) = default; ChildInfo(const ChildInfo& other) = default;
ChildInfo& operator=(const ChildInfo& other) = default;
void setSize(const std::string & sizeData) void setSize(const std::string & sizeData)
{ {
@ -586,7 +585,7 @@ private:
// emplace_back is triggering an allocation which is leading to a leak // emplace_back is triggering an allocation which is leading to a leak
// Implies that ci is lacking a proper copy-ctor/assignment-op // Implies that ci is lacking a proper copy-ctor/assignment-op
children.emplace_back(ci); children.emplace_back(ci);
children.back().path = absolutePath() / tokens[1]; children.back().path = absolutePath() / tokens[1];
if (tokens.size() > 3) { if (tokens.size() > 3) {
children.back().setSize(tokens[3]); children.back().setSize(tokens[3]);
} }