From 2b12425a622d39784a57015e3e72829a12762826 Mon Sep 17 00:00:00 2001 From: curt Date: Tue, 27 Nov 2001 03:17:43 +0000 Subject: [PATCH] Christian M. says it's bad to chain one constructor call from another. I can't find anything that addresses this in Stroustrup, but I also don't see them doing this in any of their examples. So I have rewritten this instance to use default arguments to accomplish the same thing. I imagine there are other instances of this same sort of thing in other classes to be fixed at a later date. --- simgear/route/waypoint.cxx | 5 ----- simgear/route/waypoint.hxx | 8 +++----- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/simgear/route/waypoint.cxx b/simgear/route/waypoint.cxx index 0ab3b5f9..b29d046b 100644 --- a/simgear/route/waypoint.cxx +++ b/simgear/route/waypoint.cxx @@ -38,11 +38,6 @@ SGWayPoint::SGWayPoint( const double lon, const double lat, const double alt, } -SGWayPoint::SGWayPoint() { - SGWayPoint( 0.0, 0.0, 0.0, WGS84, "" ); -} - - // Destructor SGWayPoint::~SGWayPoint() { } diff --git a/simgear/route/waypoint.hxx b/simgear/route/waypoint.hxx index aa6d8ed4..f9835977 100644 --- a/simgear/route/waypoint.hxx +++ b/simgear/route/waypoint.hxx @@ -79,9 +79,6 @@ private: public: - /** Default constructor */ - SGWayPoint(); - /** * Construct a waypoint * @param lon destination longitude @@ -90,8 +87,9 @@ public: * @param mode type of coordinates/math to use * @param s waypoint identifier */ - SGWayPoint( const double lon, const double lat, const double alt, - const modetype m = WGS84, const string s = "" ); + SGWayPoint( const double lon = 0.0, const double lat = 0.0, + const double alt = 0.0, const modetype m = WGS84, + const string s = "" ); /** Destructor */ ~SGWayPoint();