FGFS-4.1/simgear
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add try/catch wrappers in SGSubsystemGroup

Browse Source 
Attempt to narrow down the source of some fatal exceptions we see
on Senty, which occur during init/startup. All these blocks re-throw
so user behaviour is unchanged, but we’ll log the name of the subsytem.
This commit is contained in:
James Turner 2021-06-23 13:26:40 +01:00
parent 820b76d894
commit 069483e6d0
1 changed files with 27 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
simgear/structure/subsystem_mgr.cxx
View File

@ -251,10 +251,15 @@ void
SGSubsystemGroup::init () SGSubsystemGroup::init ()
{ {
assert(_state == State::BIND); assert(_state == State::BIND);
forEach([this](SGSubsystem* s){ forEach([this](SGSubsystem* s) {
this->notifyWillChange(s, State::INIT); try {
s->init(); this->notifyWillChange(s, State::INIT);
this->notifyDidChange(s, State::INIT); s->init();
this->notifyDidChange(s, State::INIT);
} catch (std::exception& e) {
simgear::reportError("Caught exception init-ing subsystem " + s->subsystemId() + "\n\t" + e.what());
throw;
}
}); });
_state = State::INIT; _state = State::INIT;
} }
@ -284,7 +289,15 @@ SGSubsystemGroup::incrementalInit()
const auto m = _members[_initPosition]; const auto m = _members[_initPosition];
SGTimeStamp st; SGTimeStamp st;
st.stamp(); st.stamp();
const InitStatus memberStatus = m->subsystem->incrementalInit(); InitStatus memberStatus;
try {
memberStatus = m->subsystem->incrementalInit();
} catch (std::exception& e) {
simgear::reportError("Caught exception init-ing subsystem " + m->subsystem->subsystemId() + "\n\t" + e.what());
throw;
}
m->initTime += st.elapsedMSec(); m->initTime += st.elapsedMSec();
if (memberStatus == INIT_DONE) { if (memberStatus == INIT_DONE) {
@ -357,10 +370,15 @@ SGSubsystemGroup::shutdown ()
void void
SGSubsystemGroup::bind () SGSubsystemGroup::bind ()
{ {
forEach([this](SGSubsystem* s){ forEach([this](SGSubsystem* s) {
this->notifyWillChange(s, State::BIND); try {
s->bind(); this->notifyWillChange(s, State::BIND);
this->notifyDidChange(s, State::BIND); s->bind();
this->notifyDidChange(s, State::BIND);
} catch (std::exception& e) {
simgear::reportError("Caught exception binding subsystem " + s->subsystemId() + "\n\t" + e.what());
throw;
}
}); });
_state = State::BIND; _state = State::BIND;
} }