FGFS-4.1/simgear
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

REVIEW: Memory Leak - hash::resize()

Browse Source 
196,628 bytes in 1 blocks are still reachable
This commit is contained in:
Scott Giese 2020-08-22 15:40:07 -05:00
parent 8f76c2b401
commit 03a76a1805
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
simgear/nasal/hash.c
View File

@ -109,6 +109,11 @@ static HashRec* resize(struct naHash* hash)
int oldsz = hr->size; int oldsz = hr->size;
while(oldsz) { oldsz >>= 1; lgsz++; } while(oldsz) { oldsz >>= 1; lgsz++; }
} }
// REVIEW: Memory Leak - 196,628 bytes in 1 blocks are still reachable
// Since method returns a HashRec*, assuming caller is responsible for freeing the memory
// trace: codegen::naInternSymbol() > naHash_set() > size()
// seems to be a known issue - refer to comment @ codegen::naInternSymbol()
hr2 = naAlloc(recsize(lgsz)); hr2 = naAlloc(recsize(lgsz));
hr2->size = hr2->next = 0; hr2->size = hr2->next = 0;
hr2->lgsz = lgsz; hr2->lgsz = lgsz;