* Move SimBrief aircraft selection to Controller
Instead of passing subfleets to blade (and doing two foreach loops and ifs to populate the dropdown), we are building a proper aircraft list here.
Did not removed $subfleets from data being passed to blade on purpose, it may be removed later on.
* Style Fix
* Update aircraft selection blade to use $aircrafts
* Order generated Aircrafts collection
First ICAO then Registration
* Add privatized name setting for simbrief
To prevent possible privacy issues according to latest regulations.
* Add privatized name to SimBrief form
It is controlled with a setting, if not enabled we will not pass any names to SimBrief via API (this will result users SimBrief membership name being used at the OFP as before)
* Refactoring simbrief fares and aircraft
* Hide user full name/email
* Sort PIREP fields desc; fix cargo counts
* Change the sorting
* Extra logs
* Fix tests
* Return fare information through the API
* Style fixes
* Test fix
* Another test fix
* More fixes
* Set aircraft and fares in prefile
* Formatting
* SimBrief Integration Update
* Added SimBrief Type field to subfleets, can be used to assign simbrief airframes to subfleets and fix non existing or wrong types. If not used simbrief form will use aircraft's icao type code
* Added Passenger and Baggage weights to settings
* Added setting for using PhpVms Pilot/User Ident as simbrief atc callsign
* SimBrief form code cleaned up a bit and improved. Now form supports both cargo and passenger fares to be used at the same time.
Generated passenger baggage weight will be reduced from aircraft's cargo capacity and remaining amount will be used for random cargo generation.
Also multiple cargo fares or any mix is possible now (like only cargo, only passenger, multiple cargo and passenger fares)
* StyleFix (SimBrief Controller)
* Fix Callsign Setting Check
* Code Cleanup
Reduced loops and removed if's in loops, getting fares from aircraft instead of flight/subfleets.
No need to go through getReconciledFaresForFlight anymore. Aircraft provides all fare info we need.
Removed unnecessary html elements, added some comments.
* Update Simbrief Controller
Fixed setting checks.
Removed non used $subfleet and from main form and $aircraft from aircraft selection form blade.
Added/fixed comments.
* StyleFix for Controller
* Failsafe for SimBrief random pax generation
PR fixes the problem for 0 load generation where va admins do not set load factor and variance values for their flights and also leave the general settings empty. In such cases, both loadmin and loadmax was returning 0 , resulting zero load.
Thanks @macofallico for figuring this out.
* StyleFix
* Refactoring for Simbrief not working #1005
* Style fixes
* Update tests for new briefing URL
* Check the OFP user
* Comment out user check temporarily
* SimBrief Planning System Update
Replaces outdated old pr.
Same improvements apply to both controller and simbrief_form.blade.
* Style Fix for SimBrief.Controller
* strict equals fix and some comments
changed equals to strict equals and put in some comments about the loadarray and manualrmk generation.
* Formatting/separate out secstohhmm
* Formatting
* Removed duplicates
We have the $wakecat, $equipment and $transponder in the controller, removed them from the blade.
Fixed a harmless typo in the IVAO Prefile DEPTIME line
Co-authored-by: Nabeel S <nabeelio@users.noreply.github.com>
Co-authored-by: Nabeel Shahzad <nabeel@nabeel.sh>
* Add SB Briefing Removal Route
Route will be called from simbrief.briefing.blade
* SimBrief Controller and Briefing Blade Update
Added the remove function to controller, which removes the simbrief ofp if no pirep_id is present, else it just nulls the flight_id for to be able to create a new SB pack
Also added the button to blade for it to work
* Style Fix
love styleci
