From fb44b73f444b1f53e0e52fc2ff855c5604d55b37 Mon Sep 17 00:00:00 2001
From: "B.Fatih KOZ" <74361521+FatihKoz@users.noreply.github.com>
Date: Fri, 4 Dec 2020 20:47:42 +0300
Subject: [PATCH] Fix METAR decoding (text correction only) (#950)

* Update Metar Decoding (Text Correction Only)

SKC means Sky Clear or Clear Skies.

Rest is ok

* Update MetarTest.php
---
 app/Support/Metar.php | 4 ++--
 tests/MetarTest.php   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/Support/Metar.php b/app/Support/Metar.php
index fb9be77a..c4cfaca7 100644
--- a/app/Support/Metar.php
+++ b/app/Support/Metar.php
@@ -172,11 +172,11 @@ class Metar implements \ArrayAccess
         'NSW'  => 'no significant weather are observed',
         'NSC'  => 'no significant clouds are observed',
         'NCD'  => 'nil cloud detected',
-        'SKC'  => 'no significant changes expected',
+        'SKC'  => 'sky is clear',
         'CLR'  => 'clear skies',
         'NOBS' => 'no observation',
         //
-        'FEW' => 'a few',
+        'FEW' => 'few',
         'SCT' => 'scattered',
         'BKN' => 'broken sky',
         'OVC' => 'overcast sky',
diff --git a/tests/MetarTest.php b/tests/MetarTest.php
index 611631d8..ad9aa98f 100644
--- a/tests/MetarTest.php
+++ b/tests/MetarTest.php
@@ -64,7 +64,7 @@ class MetarTest extends TestCase
 
         $this->assertCount(4, $parsed['clouds']);
         $this->assertEquals(
-            'A few at 1676 meters; scattered at 2896 meters; broken sky at 3353 meters; broken sky at 7010 meters',
+            'Few at 1676 meters; scattered at 2896 meters; broken sky at 3353 meters; broken sky at 7010 meters',
             $parsed['clouds_report']
         );
         $this->assertEquals(1676.4, $parsed['cloud_height']['m']);
@@ -147,8 +147,8 @@ class MetarTest extends TestCase
         $metar = Metar::parse($metar);
 
         $this->assertEquals(2, count($metar['clouds']));
-        $this->assertEquals('A few at 457 meters; a few at 7620 meters', $metar['clouds_report']);
-        $this->assertEquals('A few at 1500 feet; a few at 25000 feet', $metar['clouds_report_ft']);
+        $this->assertEquals('Few at 457 meters; few at 7620 meters', $metar['clouds_report']);
+        $this->assertEquals('Few at 1500 feet; few at 25000 feet', $metar['clouds_report_ft']);
     }
 
     /**