FGFS-4.1/phpvms
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check for blank values on import and omit them (#1266)

Browse Source 
* Check for blank values on import and omit them

* Add paused status to the pirep changed
This commit is contained in:
Nabeel S 2021-07-22 15:56:03 -04:00 committed by GitHub
parent 78d3c6b577
commit 88a8ffe48a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/Contracts/ImportExport.php
View File

@ -170,6 +170,11 @@ class ImportExport
}
foreach ($split_values as $value) {
$value = trim($value);
if ($value === '') {
continue;
}
// This isn't in the query string format, so it's
// just a straight key-value pair set
if (strpos($value, '?') === false) {

1
app/Notifications/Messages/PirepStatusChanged.php
View File

@ -44,6 +44,7 @@ class PirepStatusChanged extends Notification implements ShouldQueue
PirepStatus::LANDED => 'has landed',
PirepStatus::ARRIVED => 'has arrived',
PirepStatus::CANCELLED => 'is cancelled',
PirepStatus::PAUSED => 'is paused',
PirepStatus::EMERG_DESCENT => 'in emergency descent',
];

5
app/Services/ImportExport/FlightImporter.php
View File

@ -212,6 +212,11 @@ class FlightImporter extends ImportExport
$count = 0;
$subfleets = $this->parseMultiColumnValues($col);
foreach ($subfleets as $subfleet_type) {
$subfleet_type = trim($subfleet_type);
if (empty($subfleet_type)) {
continue;
}
$subfleet = Subfleet::firstOrCreate(
['type' => $subfleet_type],
['name' => $subfleet_type]

7
tests/ImporterTest.php
View File

@ -149,6 +149,13 @@ class ImporterTest extends TestCase
'Arrival Gate' => 'C61',
],
],
// Blank values omitted
[
'input' => 'gate; ',
'expected' => [
'gate',
],
],
];
foreach ($tests as $test) {