Fix for Hourly Crons (#1127)
* Fix for Hourly Cron We should be using whereTime instead of whereDate https://laravel.com/docs/8.x/queries#additional-where-clauses `The whereDate method may be used to compare a column's value against a date` * Fix for RemoveExpiredBids I used where to do check 'cause people may set 48 hours to remove a bid, thus neither whereDate nor whereTime will give a correct results. * Fix for DeletePireps I used where to do check 'cause people may set 48 hours to delete cancelled or rejected pireps, thus neither whereDate nor whereTime will give a correct results.
This commit is contained in:
parent
344edde0fb
commit
6c3992e781
@ -38,7 +38,7 @@ class DeletePireps extends Listener
|
||||
protected function deletePireps(int $expire_time_hours, int $state)
|
||||
{
|
||||
$dt = Carbon::now()->subHours($expire_time_hours);
|
||||
$pireps = Pirep::whereDate('created_at', '<', $dt)->where(['state' => $state])->get();
|
||||
$pireps = Pirep::where('created_at', '<', $dt)->where(['state' => $state])->get();
|
||||
|
||||
/** @var PirepService $pirepSvc */
|
||||
$pirepSvc = app(PirepService::class);
|
||||
|
@ -26,6 +26,6 @@ class RemoveExpiredBids extends Listener
|
||||
}
|
||||
|
||||
$date = Carbon::now()->subHours(setting('bids.expire_time'));
|
||||
Bid::whereDate('created_at', '<', $date)->delete();
|
||||
Bid::where('created_at', '<', $date)->delete();
|
||||
}
|
||||
}
|
||||
|
@ -27,7 +27,7 @@ class RemoveExpiredLiveFlights extends Listener
|
||||
}
|
||||
|
||||
$date = Carbon::now()->subHours(setting('acars.live_time'));
|
||||
Pirep::whereDate('updated_at', '<', $date)
|
||||
Pirep::whereTime('updated_at', '<', $date)
|
||||
->where('state', PirepState::IN_PROGRESS)
|
||||
->delete();
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user