FGFS-4.1/phpvms
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Days::in should use in_mask; tests coverage #1180 (#1193)

Browse Source
This commit is contained in:
Nabeel S 2021-05-19 11:20:50 -04:00 committed by GitHub
parent dff4273c72
commit 352f1ee9f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Models/Enums/Days.php
View File

@ -77,7 +77,7 @@ class Days extends Enum
*/ */
public static function in($mask, $day): bool public static function in($mask, $day): bool
{ {
return ($mask & $day) === $day; return in_mask($mask, $day);
} }
/** /**

9
tests/FlightTest.php
View File

@ -279,6 +279,7 @@ class FlightTest extends TestCase
*/ */
public function testDayOfWeekActive(): void public function testDayOfWeekActive(): void
{ {
/** @var User user */
$this->user = factory(User::class)->create(); $this->user = factory(User::class)->create();
// Set it to Monday or Tuesday, depending on what today is // Set it to Monday or Tuesday, depending on what today is
@ -289,6 +290,8 @@ class FlightTest extends TestCase
} }
factory(Flight::class, 5)->create(); factory(Flight::class, 5)->create();
/** @var Flight $flight */
$flight = factory(Flight::class)->create([ $flight = factory(Flight::class)->create([
'days' => $days, 'days' => $days,
]); ]);
@ -323,6 +326,12 @@ class FlightTest extends TestCase
$this->assertTrue(Days::in($mask, Days::$isoDayMap[5])); $this->assertTrue(Days::in($mask, Days::$isoDayMap[5]));
$this->assertTrue(Days::in($mask, Days::$isoDayMap[6])); $this->assertTrue(Days::in($mask, Days::$isoDayMap[6]));
$this->assertTrue(Days::in($mask, Days::$isoDayMap[7])); $this->assertTrue(Days::in($mask, Days::$isoDayMap[7]));
$mask = [];
$this->assertFalse(Days::in($mask, Days::$isoDayMap[1]));
$mask = 0;
$this->assertFalse(Days::in($mask, Days::$isoDayMap[1]));
} }
public function testStartEndDate(): void public function testStartEndDate(): void