41eb850578
CID 11447: Unchecked dynamic_cast (FORWARD_NULL) Dynamic cast to pointer "dynamic_cast <struct osg::NodeCallback *>(nc->clone(this))" can return null. Assigning null: "first" = "dynamic_cast <struct osg::NodeCallback *>(nc->clone(this))". The clone() implementation is written using macro's so that it always returns the type of Object being cloned so it's normally safe to assume that a dynamic_cast<> will always return a valid pointer as long as the new T that involves creates a valid object. However, if the class being cloned doesn't correctly implement the clone() method then their potential for the dynamic_cast to fail and will return a NULL and will result in a memory leak of the object of paraent class that the clone would have defaulted to. I've tightened up the CopyOp.cpp code to check the return type and added better handling of the clone in the osg::clone() methods so thay don't have any potential mememory leaks and report warnings to OSG_WARN when problems are encountered. It may be more apporpriate to throw an exception so will need to ponder this issue further.
233 lines
8.1 KiB
C++
233 lines
8.1 KiB
C++
/* -*-c++-*- OpenSceneGraph - Copyright (C) 1998-2006 Robert Osfield
|
|
*
|
|
* This library is open source and may be redistributed and/or modified under
|
|
* the terms of the OpenSceneGraph Public License (OSGPL) version 0.0 or
|
|
* (at your option) any later version. The full license is in LICENSE file
|
|
* included with this distribution, and on the openscenegraph.org website.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* OpenSceneGraph Public License for more details.
|
|
*/
|
|
|
|
#ifndef OSG_OBJECT
|
|
#define OSG_OBJECT 1
|
|
|
|
#include <osg/Referenced>
|
|
#include <osg/CopyOp>
|
|
#include <osg/ref_ptr>
|
|
#include <osg/Notify>
|
|
|
|
#include <string>
|
|
|
|
namespace osg {
|
|
|
|
// forward declare
|
|
class State;
|
|
|
|
#define _ADDQUOTES(def) #def
|
|
#define ADDQUOTES(def) _ADDQUOTES(def)
|
|
|
|
/** META_Object macro define the standard clone, isSameKindAs and className methods.
|
|
* Use when subclassing from Object to make it more convenient to define
|
|
* the standard pure virtual clone, isSameKindAs and className methods
|
|
* which are required for all Object subclasses.*/
|
|
#define META_Object(library,name) \
|
|
virtual osg::Object* cloneType() const { return new name (); } \
|
|
virtual osg::Object* clone(const osg::CopyOp& copyop) const { return new name (*this,copyop); } \
|
|
virtual bool isSameKindAs(const osg::Object* obj) const { return dynamic_cast<const name *>(obj)!=NULL; } \
|
|
virtual const char* libraryName() const { return #library; }\
|
|
virtual const char* className() const { return #name; }
|
|
|
|
template<typename T>
|
|
T* clone(const T* t, const osg::CopyOp& copyop=osg::CopyOp::SHALLOW_COPY)
|
|
{
|
|
if (t)
|
|
{
|
|
osg::ref_ptr<osg::Object> obj = t->clone(copyop);
|
|
|
|
T* ptr = dynamic_cast<T*>(obj.get());
|
|
if (ptr)
|
|
{
|
|
obj.release();
|
|
return ptr;
|
|
}
|
|
else
|
|
{
|
|
OSG_WARN<<"Warning: osg::clone(const T*, osg::CopyOp&) cloned object not of type T, returning NULL."<<std::endl;
|
|
return 0;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
OSG_WARN<<"Warning: osg::clone(const T*, osg::CopyOp&) passed null object to clone, returning NULL."<<std::endl;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
template<typename T>
|
|
T* clone(const T* t, const std::string& name, const osg::CopyOp& copyop=osg::CopyOp::SHALLOW_COPY)
|
|
{
|
|
T* newObject = osg::clone(t, copyop);
|
|
if (newObject)
|
|
{
|
|
newObject->setName(name);
|
|
return newObject;
|
|
}
|
|
else
|
|
{
|
|
OSG_WARN<<"Warning: osg::clone(const T*, const std::string&, const osg::CopyOp) passed null object to clone, returning NULL."<<std::endl;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
template<typename T>
|
|
T* cloneType(const T* t)
|
|
{
|
|
if (t)
|
|
{
|
|
osg::ref_ptr<osg::Object> obj = t->cloneType();
|
|
|
|
T* ptr = dynamic_cast<T*>(obj.get());
|
|
if (ptr)
|
|
{
|
|
obj.release();
|
|
return ptr;
|
|
}
|
|
else
|
|
{
|
|
OSG_WARN<<"Warning: osg::cloneType(const T*) cloned object not of type T, returning NULL."<<std::endl;
|
|
return 0;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
OSG_WARN<<"Warning: osg::cloneType(const T*) passed null object to clone, returning NULL."<<std::endl;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
/** Base class/standard interface for objects which require IO support,
|
|
cloning and reference counting.
|
|
Based on GOF Composite, Prototype and Template Method patterns.
|
|
*/
|
|
class OSG_EXPORT Object : public Referenced
|
|
{
|
|
public:
|
|
|
|
|
|
/** Construct an object. Note Object is a pure virtual base class
|
|
and therefore cannot be constructed on its own, only derived
|
|
classes which override the clone and className methods are
|
|
concrete classes and can be constructed.*/
|
|
inline Object():Referenced(),_dataVariance(UNSPECIFIED) {}
|
|
|
|
inline explicit Object(bool threadSafeRefUnref):Referenced(threadSafeRefUnref),_dataVariance(UNSPECIFIED) {}
|
|
|
|
/** Copy constructor, optional CopyOp object can be used to control
|
|
* shallow vs deep copying of dynamic data.*/
|
|
Object(const Object&,const CopyOp& copyop=CopyOp::SHALLOW_COPY);
|
|
|
|
/** Clone the type of an object, with Object* return type.
|
|
Must be defined by derived classes.*/
|
|
virtual Object* cloneType() const = 0;
|
|
|
|
/** Clone an object, with Object* return type.
|
|
Must be defined by derived classes.*/
|
|
virtual Object* clone(const CopyOp&) const = 0;
|
|
|
|
virtual bool isSameKindAs(const Object*) const { return true; }
|
|
|
|
/** return the name of the object's library. Must be defined
|
|
by derived classes. The OpenSceneGraph convention is that the
|
|
namespace of a library is the same as the library name.*/
|
|
virtual const char* libraryName() const = 0;
|
|
|
|
/** return the name of the object's class type. Must be defined
|
|
by derived classes.*/
|
|
virtual const char* className() const = 0;
|
|
|
|
|
|
/** Set the name of object using C++ style string.*/
|
|
virtual void setName( const std::string& name ) { _name = name; }
|
|
|
|
/** Set the name of object using a C style string.*/
|
|
inline void setName( const char* name )
|
|
{
|
|
if (name) setName(std::string(name));
|
|
else setName(std::string());
|
|
}
|
|
|
|
/** Get the name of object.*/
|
|
inline const std::string& getName() const { return _name; }
|
|
|
|
|
|
enum DataVariance
|
|
{
|
|
DYNAMIC,
|
|
STATIC,
|
|
UNSPECIFIED
|
|
};
|
|
|
|
/** Set the data variance of this object.
|
|
* Can be set to either STATIC for values that do not change over the lifetime of the object,
|
|
* or DYNAMIC for values that vary over the lifetime of the object. The DataVariance value
|
|
* can be used by routines such as optimization codes that wish to share static data.
|
|
* UNSPECIFIED is used to specify that the DataVariance hasn't been set yet. */
|
|
inline void setDataVariance(DataVariance dv) { _dataVariance = dv; }
|
|
|
|
/** Get the data variance of this object.*/
|
|
inline DataVariance getDataVariance() const { return _dataVariance; }
|
|
|
|
/** Compute the DataVariance based on an assessment of callback etc.*/
|
|
virtual void computeDataVariance() {}
|
|
|
|
|
|
/**
|
|
* Set user data, data must be subclassed from Referenced to allow
|
|
* automatic memory handling. If your own data isn't directly
|
|
* subclassed from Referenced then create an adapter object
|
|
* which points to your own object and handles the memory addressing.
|
|
*/
|
|
inline void setUserData(Referenced* obj) { _userData = obj; }
|
|
|
|
/** Get user data.*/
|
|
inline Referenced* getUserData() { return _userData.get(); }
|
|
|
|
/** Get const user data.*/
|
|
inline const Referenced* getUserData() const { return _userData.get(); }
|
|
|
|
/** Resize any per context GLObject buffers to specified size. */
|
|
virtual void resizeGLObjectBuffers(unsigned int /*maxSize*/) {}
|
|
|
|
/** If State is non-zero, this function releases any associated OpenGL objects for
|
|
* the specified graphics context. Otherwise, releases OpenGL objects
|
|
* for all graphics contexts. */
|
|
virtual void releaseGLObjects(osg::State* = 0) const {}
|
|
|
|
protected:
|
|
|
|
/** Object destructor. Note, is protected so that Objects cannot
|
|
be deleted other than by being dereferenced and the reference
|
|
count being zero (see osg::Referenced), preventing the deletion
|
|
of nodes which are still in use. This also means that
|
|
Nodes cannot be created on stack i.e Node node will not compile,
|
|
forcing all nodes to be created on the heap i.e Node* node
|
|
= new Node().*/
|
|
virtual ~Object() {}
|
|
|
|
std::string _name;
|
|
DataVariance _dataVariance;
|
|
ref_ptr<Referenced> _userData;
|
|
|
|
private:
|
|
|
|
/** disallow any copy operator.*/
|
|
Object& operator = (const Object&) { return *this; }
|
|
};
|
|
|
|
}
|
|
|
|
#endif
|