FGFS-4.1/OpenSceneGraph
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1678dc3562
OpenSceneGraph/include/osgGA
History
Robert Osfield e04e03d695 From Jordi Torres, "We have a code using gcc with -Wextra flag and using OSG as a third party library. It does not compile when importing <osgViewer/Viewer> failing in EventHandler and GUIEventHandler: 
....

GUIEventHandler: In copy constructor 'osgGA::GUIEventHandler::GUIEventHandler(const osgGA::GUIEventHandler&, const osg::CopyOp&)':

/include/osgGA/GUIEventHandler:56:9: error: base class 'class osg::Object' should be explicitly initialized in the copy constructor [-Werror=extra]

It seems the diamond problem:

   A = osg::Object
  / \
 /   \--> Virtual inheritance
B     C
 \   /
  \ /
   D = EventHandler
   |
   |
   E = GUIEventHandler

The most derived class(E)  handles the instantiation of A (osg::Object), but all have to be responsible in case they are the ones instantiated.


In case A is not initialized in the copy constructor of derived classes the default constructor will be called, which seems a bug.

I've added osg::Object to the initalization list of EventHandler and GUIEventHandler copy constructors, because both classes are instantiables.
 "
2014-01-17 13:59:29 +00:00
..
AnimationPathManipulator Ran script to remove trailing spaces and tabs 2012-03-21 17:36:20 +00:00
CameraManipulator Moved Handled propety from GUIEventAdapter to Event base class. 2013-11-15 16:15:09 +00:00
CameraViewSwitchManipulator Ran script to remove trailing spaces and tabs 2012-03-21 17:36:20 +00:00
Device Introduce new osgGA::Event and osgGA::EventHandler base classes that the old GUIEventAdapter and GUIEventHandler now subclass from. 2013-10-25 14:54:15 +00:00
DriveManipulator From Magnus Kessler, "I'm resubmitting a slightly different version of the changes you left out for 2010-09-16 09:49:22 +00:00
Event Moved Handled propety from GUIEventAdapter to Event base class. 2013-11-15 16:15:09 +00:00
EventHandler From Jordi Torres, "We have a code using gcc with -Wextra flag and using OSG as a third party library. It does not compile when importing <osgViewer/Viewer> failing in EventHandler and GUIEventHandler: 2014-01-17 13:59:29 +00:00
EventQueue Introduce new osgGA::Event and osgGA::EventHandler base classes that the old GUIEventAdapter and GUIEventHandler now subclass from. 2013-10-25 14:54:15 +00:00
EventVisitor Introduce new osgGA::Event and osgGA::EventHandler base classes that the old GUIEventAdapter and GUIEventHandler now subclass from. 2013-10-25 14:54:15 +00:00
Export Ran script to remove trailing spaces and tabs 2012-03-21 17:36:20 +00:00
FirstPersonManipulator Changed setTransformation(eye, center, up) paramter ordering to match gluLookAt conventions. 2010-08-16 11:03:24 +00:00
FlightManipulator From Magnus Kessler, typo and documentation fixes 2012-03-29 15:08:15 +00:00
GUIActionAdapter From Magnus Kessler, typo and documentation fixes 2012-03-29 15:08:15 +00:00
GUIEventAdapter From Stephan Huber, * GUIEventAdapter: add support for getting normalized touch points 2013-11-18 13:25:55 +00:00
GUIEventHandler From Jordi Torres, "We have a code using gcc with -Wextra flag and using OSG as a third party library. It does not compile when importing <osgViewer/Viewer> failing in EventHandler and GUIEventHandler: 2014-01-17 13:59:29 +00:00
KeySwitchMatrixManipulator Moved Handled propety from GUIEventAdapter to Event base class. 2013-11-15 16:15:09 +00:00
MultiTouchTrackballManipulator From Stephan Huber, * GUIEventAdapter: add support for getting normalized touch points 2013-11-18 13:25:55 +00:00
NodeTrackerManipulator Refactored NodeTrackerManipulator to use osg::ObserverNodePath rather than it's only local equivilant. 2011-02-03 17:07:01 +00:00
OrbitManipulator Fixed parameter default value to avoid warning 2012-07-11 08:39:11 +00:00
SphericalManipulator Ran script to remove trailing spaces and tabs 2012-03-21 17:36:20 +00:00
StandardManipulator From Wojciech Lewandowski, "We encountered a problem when we tried overloading StandardManipulator class. Linker was unable to find StandardManipulator::AnimationData methods. Prefixing AnimationData with OSGGA_EXPORT removed the issue. 2011-01-11 17:20:25 +00:00
StateSetManipulator Ran script to remove trailing spaces and tabs 2012-03-21 17:36:20 +00:00
TerrainManipulator From Jan Pecvia, improvements to manipulators and added new manipulator to osgviewer 2010-05-27 13:59:34 +00:00
TrackballManipulator From Jan Pecvia, improvements to manipulators and added new manipulator to osgviewer 2010-05-27 13:59:34 +00:00
UFOManipulator Ran script to remove trailing spaces and tabs 2012-03-21 17:36:20 +00:00
Version Ran script to remove trailing spaces and tabs 2012-03-21 17:36:20 +00:00