FGFS-4.1/OpenSceneGraph
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed Coverity issue.

Browse Source 
CID 11695: Uninitialized pointer field (UNINIT_CTOR)
Non-static class member _ximpl is not initialized in this constructor nor in any functions that it calls.
This commit is contained in:
Robert Osfield 2011-05-24 10:15:17 +00:00
parent 930f3e4974
commit f2674b2911
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/osg/FrameBufferObject.cpp
View File

@ -499,15 +499,20 @@ FrameBufferAttachment::FrameBufferAttachment(Camera::Attachment& attachment)
format = attachment._internalFormat; format = attachment._internalFormat;
_ximpl = new Pimpl(Pimpl::RENDERBUFFER); _ximpl = new Pimpl(Pimpl::RENDERBUFFER);
_ximpl->renderbufferTarget = new osg::RenderBuffer(image->s(), image->t(), format); _ximpl->renderbufferTarget = new osg::RenderBuffer(image->s(), image->t(), format);
return;
} }
else else
{ {
OSG_WARN<<"Error: FrameBufferAttachment::FrameBufferAttachment(Camera::Attachment&) passed an empty osg::Image, image must be allocated first."<<std::endl; OSG_WARN<<"Error: FrameBufferAttachment::FrameBufferAttachment(Camera::Attachment&) passed an empty osg::Image, image must be allocated first."<<std::endl;
} }
return; }
else
{
OSG_WARN<<"Error: FrameBufferAttachment::FrameBufferAttachment(Camera::Attachment&) passed an unrecognised Texture type."<<std::endl;
} }
OSG_WARN<<"Error: FrameBufferAttachment::FrameBufferAttachment(Camera::Attachment&) passed an unrecognised Texture type."<<std::endl; // provide all fallback
_ximpl = new Pimpl();
} }