FGFS-4.1/OpenSceneGraph
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed 1 Coverity Low Impact issue "Unused pointer value (UNUSED_VALUE)

Browse Source 
Pointer "indices" returned by "this->_vertexAttribList[0ULL].indices.get()" is never used."

Report highlighted the fact that later code wasn't using the indices variable when it should have been, so
potentially a higher impact that the severity suggested by Coverity.
This commit is contained in:
Robert Osfield 2011-04-26 19:31:04 +00:00
parent c19fcd6d44
commit e345a7bacd
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/osg/Geometry.cpp
View File

@ -1764,7 +1764,7 @@ void Geometry::accept(PrimitiveIndexFunctor& functor) const
return;
}
if (!_vertexData.indices.valid())
if (!indices)
{
for(PrimitiveSetList::const_iterator itr=_primitives.begin();
itr!=_primitives.end();
@ -1793,7 +1793,7 @@ void Geometry::accept(PrimitiveIndexFunctor& functor) const
vindex<indexEnd;
++vindex)
{
functor.vertex(_vertexData.indices->index(vindex));
functor.vertex(indices->index(vindex));
}
functor.end();
@ -1813,7 +1813,7 @@ void Geometry::accept(PrimitiveIndexFunctor& functor) const
for(GLsizei primCount=0;primCount<*primItr;++primCount)
{
functor.vertex(_vertexData.indices->index(vindex));
functor.vertex(indices->index(vindex));
++vindex;
}
@ -1833,7 +1833,7 @@ void Geometry::accept(PrimitiveIndexFunctor& functor) const
++primCount,++primItr)
{
unsigned int vindex=*primItr;
functor.vertex(_vertexData.indices->index(vindex));
functor.vertex(indices->index(vindex));
}
functor.end();
@ -1849,7 +1849,7 @@ void Geometry::accept(PrimitiveIndexFunctor& functor) const
++primItr)
{
unsigned int vindex=*primItr;
functor.vertex(_vertexData.indices->index(vindex));
functor.vertex(indices->index(vindex));
}
functor.end();
@ -1865,7 +1865,7 @@ void Geometry::accept(PrimitiveIndexFunctor& functor) const
++primItr)
{
unsigned int vindex=*primItr;
functor.vertex(_vertexData.indices->index(vindex));
functor.vertex(indices->index(vindex));
}
functor.end();