From 7f2481e976327efe79f34c4248f33c727910c119 Mon Sep 17 00:00:00 2001 From: Julien Valentin Date: Wed, 6 Dec 2017 22:57:03 +0100 Subject: [PATCH] add a fix in order setArray work with an user managed interleaved array --- src/osg/VertexArrayState.cpp | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/src/osg/VertexArrayState.cpp b/src/osg/VertexArrayState.cpp index 7af9bec4a..f0bc391d1 100644 --- a/src/osg/VertexArrayState.cpp +++ b/src/osg/VertexArrayState.cpp @@ -483,6 +483,14 @@ struct VertexAttribArrayDispatch : public VertexArrayState::ArrayDispatch callVertexAttribPointer(ext, new_array, (const GLvoid *)(vbo->getOffset(new_array->getBufferIndex()))); } + virtual void enable_and_dispatch(osg::State& state, GLint size, GLenum type, GLsizei stride, const GLvoid *ptr, GLboolean normalized) + { + GLExtensions* ext = state.get(); + + ext->glEnableVertexAttribArray( unit ); + ext->glVertexAttribPointer(static_cast(unit), size, type, normalized, stride, ptr); + } + virtual void dispatch(osg::State& state, const osg::Array* new_array) { GLExtensions* ext = state.get(); @@ -713,30 +721,20 @@ void VertexArrayState::setArray(ArrayDispatch* vad, osg::State& state, const osg void VertexArrayState::setArray(ArrayDispatch* vad, osg::State& state, GLint size, GLenum type, GLsizei stride, const GLvoid *ptr, GLboolean normalized) { - if (ptr) - { + if(!vad->array){ + if (!vad->active) { vad->active = true; _activeDispatchers.push_back(vad); } - if (vad->array==0) - { - unbindVertexBufferObject(); - vad->enable_and_dispatch(state, size, type, stride, ptr, normalized); - } - else - { - unbindVertexBufferObject(); - vad->dispatch(state, size, type, stride, ptr, normalized); - } + vad->enable_and_dispatch(state, size, type, stride, ptr, normalized); - vad->array = 0; vad->modifiedCount = 0xffffffff; } - else if (vad->array) + else { disable(vad, state); }