FGFS-4.1/OpenSceneGraph
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #934 from mp3butcher/orphanalreadyimmutable

Browse Source 
[osg3.6] prevent immutability setting when textureobject is taken from orphans
This commit is contained in:
OpenSceneGraph git repository 2020-05-03 09:37:44 +01:00 committed by GitHub
commit 6ca2487362
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 37 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/osg/Texture1D.cpp
View File

@ -238,13 +238,15 @@ void Texture1D::apply(State& state) const
textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_1D, _numMipmapLevels, texStorageSizedInternalFormat, _textureWidth, 1, 1, 0); textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_1D, _numMipmapLevels, texStorageSizedInternalFormat, _textureWidth, 1, 1, 0);
textureObject->bind(); textureObject->bind();
applyTexParameters(GL_TEXTURE_1D, state); applyTexParameters(GL_TEXTURE_1D, state);
if(!textureObject->_allocated)
{
extensions->glTexStorage1D( GL_TEXTURE_1D, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth); extensions->glTexStorage1D( GL_TEXTURE_1D, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth);
} }
}
else else
{ {
GLenum internalFormat = _sourceFormat ? _sourceFormat : _internalFormat; GLenum internalFormat = _sourceFormat ? _sourceFormat : _internalFormat;
textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_1D, _numMipmapLevels, internalFormat, _textureWidth, 1, 1, 0); textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_1D, _numMipmapLevels, internalFormat, _textureWidth, 1, 1, _borderWidth);
textureObject->bind(); textureObject->bind();
applyTexParameters(GL_TEXTURE_1D, state); applyTexParameters(GL_TEXTURE_1D, state);
@ -260,6 +262,8 @@ void Texture1D::apply(State& state) const
_readPBuffer->bindPBufferToTexture(GL_FRONT); _readPBuffer->bindPBufferToTexture(GL_FRONT);
} }
textureObject->setAllocated(_numMipmapLevels, texStorageSizedInternalFormat!=0? texStorageSizedInternalFormat: _internalFormat, _textureWidth, 1, 1, _borderWidth);
} }
else else
{ {

4
src/osg/Texture2D.cpp
View File

@ -306,9 +306,12 @@ void Texture2D::apply(State& state) const
textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_2D, _numMipmapLevels, texStorageSizedInternalFormat, _textureWidth, _textureHeight, 1, _borderWidth); textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_2D, _numMipmapLevels, texStorageSizedInternalFormat, _textureWidth, _textureHeight, 1, _borderWidth);
textureObject->bind(); textureObject->bind();
applyTexParameters(GL_TEXTURE_2D, state); applyTexParameters(GL_TEXTURE_2D, state);
if(!textureObject->_allocated)
{
extensions->glTexStorage2D( GL_TEXTURE_2D, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, extensions->glTexStorage2D( GL_TEXTURE_2D, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat,
_textureWidth, _textureHeight); _textureWidth, _textureHeight);
} }
}
else else
{ {
GLenum internalFormat = _sourceFormat ? _sourceFormat : _internalFormat; GLenum internalFormat = _sourceFormat ? _sourceFormat : _internalFormat;
@ -327,6 +330,7 @@ void Texture2D::apply(State& state) const
_readPBuffer->bindPBufferToTexture(GL_FRONT); _readPBuffer->bindPBufferToTexture(GL_FRONT);
} }
textureObject->setAllocated(_numMipmapLevels, texStorageSizedInternalFormat!=0? texStorageSizedInternalFormat: _internalFormat, _textureWidth, _textureHeight, 1, _borderWidth);
} }
else else
{ {

6
src/osg/Texture2DArray.cpp
View File

@ -353,7 +353,7 @@ void Texture2DArray::apply(State& state) const
applyTexParameters(GL_TEXTURE_2D_ARRAY, state); applyTexParameters(GL_TEXTURE_2D_ARRAY, state);
// First we need to allocate the texture memory // First we need to allocate the texture memory
if(texStorageSizedInternalFormat!=0) if(texStorageSizedInternalFormat!=0 && !textureObject->_allocated)
{ {
extensions->glTexStorage3D(GL_TEXTURE_2D_ARRAY, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth, _textureHeight, textureDepth); extensions->glTexStorage3D(GL_TEXTURE_2D_ARRAY, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth, _textureHeight, textureDepth);
} }
@ -452,7 +452,7 @@ void Texture2DArray::apply(State& state) const
applyTexParameters(GL_TEXTURE_2D_ARRAY,state); applyTexParameters(GL_TEXTURE_2D_ARRAY,state);
if (texStorageSizedInternalFormat!=0) if (texStorageSizedInternalFormat!=0 && !textureObject->_allocated)
{ {
extensions->glTexStorage3D( GL_TEXTURE_2D_ARRAY, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth, _textureHeight, _textureDepth); extensions->glTexStorage3D( GL_TEXTURE_2D_ARRAY, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth, _textureHeight, _textureDepth);
} }
@ -463,6 +463,8 @@ void Texture2DArray::apply(State& state) const
_sourceFormat ? _sourceFormat : _internalFormat, _sourceFormat ? _sourceFormat : _internalFormat,
_sourceType ? _sourceType : GL_UNSIGNED_BYTE, _sourceType ? _sourceType : GL_UNSIGNED_BYTE,
0); 0);
textureObject->setAllocated(_numMipmapLevels, texStorageSizedInternalFormat!=0 ? texStorageSizedInternalFormat :_internalFormat, _textureWidth, _textureHeight, _textureDepth, 0);
} }
// nothing before, so just unbind the texture target // nothing before, so just unbind the texture target

5
src/osg/Texture2DMultisample.cpp
View File

@ -108,9 +108,11 @@ void Texture2DMultisample::apply(State& state) const
{ {
textureObject = generateAndAssignTextureObject(contextID, getTextureTarget(), 1, texStorageSizedInternalFormat, _textureWidth, _textureHeight, 1, 0); textureObject = generateAndAssignTextureObject(contextID, getTextureTarget(), 1, texStorageSizedInternalFormat, _textureWidth, _textureHeight, 1, 0);
textureObject->bind(); textureObject->bind();
if(!textureObject->_allocated)
{
extensions->glTexStorage2DMultisample( GL_TEXTURE_2D_MULTISAMPLE, _numSamples, texStorageSizedInternalFormat, _textureWidth, _textureHeight, _fixedsamplelocations); extensions->glTexStorage2DMultisample( GL_TEXTURE_2D_MULTISAMPLE, _numSamples, texStorageSizedInternalFormat, _textureWidth, _textureHeight, _fixedsamplelocations);
} }
}
else else
{ {
textureObject = generateAndAssignTextureObject(contextID, getTextureTarget(), 1, _internalFormat, _textureWidth, _textureHeight, 1, _borderWidth); textureObject = generateAndAssignTextureObject(contextID, getTextureTarget(), 1, _internalFormat, _textureWidth, _textureHeight, 1, _borderWidth);
@ -123,6 +125,7 @@ void Texture2DMultisample::apply(State& state) const
_textureHeight, _textureHeight,
_fixedsamplelocations ); _fixedsamplelocations );
} }
textureObject->setAllocated(1, texStorageSizedInternalFormat!=0? texStorageSizedInternalFormat: _internalFormat, _textureWidth, _textureHeight, 1, _borderWidth);
} }
else else

5
src/osg/Texture3D.cpp
View File

@ -322,9 +322,11 @@ void Texture3D::apply(State& state) const
textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_3D, _numMipmapLevels, texStorageSizedInternalFormat, _textureWidth, _textureHeight, _textureDepth,0); textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_3D, _numMipmapLevels, texStorageSizedInternalFormat, _textureWidth, _textureHeight, _textureDepth,0);
textureObject->bind(); textureObject->bind();
applyTexParameters(GL_TEXTURE_3D, state); applyTexParameters(GL_TEXTURE_3D, state);
if(!textureObject->_allocated)
{
extensions->glTexStorage3D( GL_TEXTURE_3D, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth, _textureHeight, _textureDepth); extensions->glTexStorage3D( GL_TEXTURE_3D, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth, _textureHeight, _textureDepth);
} }
}
else else
{ {
GLenum internalFormat = _sourceFormat ? _sourceFormat : _internalFormat; GLenum internalFormat = _sourceFormat ? _sourceFormat : _internalFormat;
@ -345,6 +347,7 @@ void Texture3D::apply(State& state) const
_readPBuffer->bindPBufferToTexture(GL_FRONT); _readPBuffer->bindPBufferToTexture(GL_FRONT);
} }
textureObject->setAllocated(_numMipmapLevels, texStorageSizedInternalFormat!=0? texStorageSizedInternalFormat : _internalFormat, _textureWidth, _textureHeight, _textureDepth, _borderWidth);
} }
else else
{ {

4
src/osg/TextureCubeMap.cpp
View File

@ -352,8 +352,11 @@ void TextureCubeMap::apply(State& state) const
applyTexParameters(GL_TEXTURE_CUBE_MAP,state); applyTexParameters(GL_TEXTURE_CUBE_MAP,state);
if(texStorageSizedInternalFormat!=0) if(texStorageSizedInternalFormat!=0)
{
if(!textureObject->_allocated)
{ {
extensions->glTexStorage2D(GL_TEXTURE_CUBE_MAP, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth, _textureHeight); extensions->glTexStorage2D(GL_TEXTURE_CUBE_MAP, osg::maximum(_numMipmapLevels,1), texStorageSizedInternalFormat, _textureWidth, _textureHeight);
}
} }
else else
@ -367,6 +370,7 @@ void TextureCubeMap::apply(State& state) const
0); 0);
} }
textureObject->setAllocated(_numMipmapLevels, texStorageSizedInternalFormat!=0? texStorageSizedInternalFormat : _internalFormat, _textureWidth, _textureHeight, 1, 0);
} }
else else
{ {

5
src/osg/TextureRectangle.cpp
View File

@ -281,9 +281,11 @@ void TextureRectangle::apply(State& state) const
textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_RECTANGLE, 0, texStorageSizedInternalFormat, _textureWidth, _textureHeight, 1, 0); textureObject = generateAndAssignTextureObject(contextID, GL_TEXTURE_RECTANGLE, 0, texStorageSizedInternalFormat, _textureWidth, _textureHeight, 1, 0);
textureObject->bind(); textureObject->bind();
applyTexParameters(GL_TEXTURE_RECTANGLE, state); applyTexParameters(GL_TEXTURE_RECTANGLE, state);
if(!textureObject->_allocated)
{
extensions->glTexStorage2D( GL_TEXTURE_RECTANGLE, 1, texStorageSizedInternalFormat, _textureWidth, _textureHeight); extensions->glTexStorage2D( GL_TEXTURE_RECTANGLE, 1, texStorageSizedInternalFormat, _textureWidth, _textureHeight);
} }
}
else else
{ {
GLenum internalFormat = _sourceFormat ? _sourceFormat : _internalFormat; GLenum internalFormat = _sourceFormat ? _sourceFormat : _internalFormat;
@ -303,6 +305,7 @@ void TextureRectangle::apply(State& state) const
_readPBuffer->bindPBufferToTexture(GL_FRONT); _readPBuffer->bindPBufferToTexture(GL_FRONT);
} }
textureObject->setAllocated(0, texStorageSizedInternalFormat!=0? texStorageSizedInternalFormat : _internalFormat, _textureWidth, _textureHeight, 1, 0);
} }
else else
{ {